Netdev List
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: Hisashi T Fujinaka <htodd@twofifty.com>
Cc: "Alexander Duyck" <alexander.duyck@gmail.com>,
	Netdev <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Cao jin" <caoj.fnst@cn.fujitsu.com>,
	intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
	"Izumi, Taku/泉 拓" <izumi.taku@jp.fujitsu.com>
Subject: Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr
Date: Thu, 10 Nov 2016 18:28:07 +0100	[thread overview]
Message-ID: <20161110172807.GH24351@calimero.vinschen.de> (raw)
In-Reply-To: <alpine.NEB.2.20.17.1611100544220.6177@chris.i8u.org>

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On Nov 10 05:48, Hisashi T Fujinaka wrote:
> On Thu, 10 Nov 2016, Corinna Vinschen wrote:
> > On Nov  8 11:33, Alexander Duyck wrote:
> ...
> > > The question I would have is what is reading the device when it is in
> > > this state.  The watchdog and any other functions that would read the
> > > device should be disabled.
> > > 
> > > One possibility could be a race between a call to igb_close and the
> > > igb_suspend function.  We have seen some of those pop up recently on
> > > ixgbe and it looks like igb has the same bug.  We should probably be
> > > using the rtnl_lock to guarantee that netif_device_detach and the call
> > > to __igb_close are completed before igb_close could possibly be called
> > > by the network stack.
> > 
> > Do you have a pointer to the related ixgbe patch, by any chance?
> ...
> Here's the initial patch for igb I have, but it's on hold awaiting more
> changes in ixgbe regarding AER.

Thanks a lot!


Corinna

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-11-10 17:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08  7:06 [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr Cao jin
2016-11-08 16:42 ` [Intel-wired-lan] " Corinna Vinschen
2016-11-08 17:16   ` Hisashi T Fujinaka
2016-11-08 18:32     ` Hisashi T Fujinaka
2016-11-08 18:37     ` Corinna Vinschen
2016-11-08 19:33       ` Alexander Duyck
2016-11-09 13:28         ` Cao jin
2016-11-10  9:35         ` Corinna Vinschen
2016-11-10 13:48           ` Hisashi T Fujinaka
2016-11-10 17:28             ` Corinna Vinschen [this message]
2016-11-09 16:28 ` Alexander Duyck
2016-11-23 23:48 ` [Intel-wired-lan] " Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161110172807.GH24351@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=alexander.duyck@gmail.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=htodd@twofifty.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox