* [net-next] macvtap: replace printk with netdev_err
@ 2016-11-29 3:26 Zhang Shengju
2016-11-29 10:04 ` Jason Wang
2016-11-30 17:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Shengju @ 2016-11-29 3:26 UTC (permalink / raw)
To: netdev; +Cc: jasowang
This patch replaces printk() with netdev_err() for macvtap device.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
drivers/net/macvtap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 5da9861..2513939 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -437,7 +437,7 @@ static int macvtap_get_minor(struct macvlan_dev *vlan)
if (retval >= 0) {
vlan->minor = retval;
} else if (retval == -ENOSPC) {
- printk(KERN_ERR "too many macvtap devices\n");
+ netdev_err(vlan->dev, "Too many macvtap devices\n");
retval = -EINVAL;
}
mutex_unlock(&minor_lock);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [net-next] macvtap: replace printk with netdev_err
2016-11-29 3:26 [net-next] macvtap: replace printk with netdev_err Zhang Shengju
@ 2016-11-29 10:04 ` Jason Wang
2016-11-30 17:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2016-11-29 10:04 UTC (permalink / raw)
To: Zhang Shengju, netdev
On 2016年11月29日 11:26, Zhang Shengju wrote:
> This patch replaces printk() with netdev_err() for macvtap device.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> ---
> drivers/net/macvtap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
> index 5da9861..2513939 100644
> --- a/drivers/net/macvtap.c
> +++ b/drivers/net/macvtap.c
> @@ -437,7 +437,7 @@ static int macvtap_get_minor(struct macvlan_dev *vlan)
> if (retval >= 0) {
> vlan->minor = retval;
> } else if (retval == -ENOSPC) {
> - printk(KERN_ERR "too many macvtap devices\n");
> + netdev_err(vlan->dev, "Too many macvtap devices\n");
> retval = -EINVAL;
> }
> mutex_unlock(&minor_lock);
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net-next] macvtap: replace printk with netdev_err
2016-11-29 3:26 [net-next] macvtap: replace printk with netdev_err Zhang Shengju
2016-11-29 10:04 ` Jason Wang
@ 2016-11-30 17:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-11-30 17:41 UTC (permalink / raw)
To: zhangshengju; +Cc: netdev, jasowang
From: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Date: Tue, 29 Nov 2016 11:26:32 +0800
> This patch replaces printk() with netdev_err() for macvtap device.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-30 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-29 3:26 [net-next] macvtap: replace printk with netdev_err Zhang Shengju
2016-11-29 10:04 ` Jason Wang
2016-11-30 17:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox