From: Francois Romieu <romieu@fr.zoreil.com>
To: Rayagond Kokatanur <rayagond.kokatanur@gmail.com>
Cc: siva.kallam@samsung.com, bh74.an@samsung.com,
ks.giri@samsung.com, vipul.pandya@samsung.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net:ethernet:samsung:initialize cur_rx_qnum
Date: Fri, 9 Dec 2016 23:42:03 +0100 [thread overview]
Message-ID: <20161209224203.GA8878@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1481285645-6028-1-git-send-email-rayagond.kokatanur@gmail.com>
Rayagond Kokatanur <rayagond.kokatanur@gmail.com> :
> This patch initialize the cur_rx_qnum upon occurence of rx interrupt,
> without this initialization driver will not work with multiple rx queues
> configurations.
>
> NOTE: This patch is not tested on actual hw.
(your patch should include a Signed-off-by)
Imho the driver needs more changes to support multiple rx queues.
- rx interrupt for queue A -> priv->cur_rx_qnum = A
- rx interrupt for queue B -> priv->cur_rx_qnum = B
- rx napi processing -> Err...
Please start turning priv->cur_rx_qnum into a SXGBE_RX_QUEUES sized bitmap.
--
Ueimor
prev parent reply other threads:[~2016-12-09 22:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 12:14 [PATCH] net:ethernet:samsung:initialize cur_rx_qnum Rayagond Kokatanur
2016-12-09 22:42 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209224203.GA8878@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=bh74.an@samsung.com \
--cc=ks.giri@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=rayagond.kokatanur@gmail.com \
--cc=siva.kallam@samsung.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox