* [PATCH] net:ethernet:samsung:initialize cur_rx_qnum
@ 2016-12-09 12:14 Rayagond Kokatanur
2016-12-09 22:42 ` Francois Romieu
0 siblings, 1 reply; 2+ messages in thread
From: Rayagond Kokatanur @ 2016-12-09 12:14 UTC (permalink / raw)
To: siva.kallam, bh74.an, ks.giri, vipul.pandya; +Cc: netdev, Rayagond Kokatanur
This patch initialize the cur_rx_qnum upon occurence of rx interrupt,
without this initialization driver will not work with multiple rx queues configurations.
NOTE: This patch is not tested on actual hw.
---
drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
index ea44a24..580a1a4 100644
--- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
+++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c
@@ -1681,6 +1681,7 @@ static irqreturn_t sxgbe_rx_interrupt(int irq, void *dev_id)
struct sxgbe_rx_queue *rxq = (struct sxgbe_rx_queue *)dev_id;
struct sxgbe_priv_data *priv = rxq->priv_ptr;
+ priv->cur_rx_qnum = rxq->queue_no;
/* get the channel status */
status = priv->hw->dma->rx_dma_int_status(priv->ioaddr, rxq->queue_no,
&priv->xstats);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net:ethernet:samsung:initialize cur_rx_qnum
2016-12-09 12:14 [PATCH] net:ethernet:samsung:initialize cur_rx_qnum Rayagond Kokatanur
@ 2016-12-09 22:42 ` Francois Romieu
0 siblings, 0 replies; 2+ messages in thread
From: Francois Romieu @ 2016-12-09 22:42 UTC (permalink / raw)
To: Rayagond Kokatanur; +Cc: siva.kallam, bh74.an, ks.giri, vipul.pandya, netdev
Rayagond Kokatanur <rayagond.kokatanur@gmail.com> :
> This patch initialize the cur_rx_qnum upon occurence of rx interrupt,
> without this initialization driver will not work with multiple rx queues
> configurations.
>
> NOTE: This patch is not tested on actual hw.
(your patch should include a Signed-off-by)
Imho the driver needs more changes to support multiple rx queues.
- rx interrupt for queue A -> priv->cur_rx_qnum = A
- rx interrupt for queue B -> priv->cur_rx_qnum = B
- rx napi processing -> Err...
Please start turning priv->cur_rx_qnum into a SXGBE_RX_QUEUES sized bitmap.
--
Ueimor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-09 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-09 12:14 [PATCH] net:ethernet:samsung:initialize cur_rx_qnum Rayagond Kokatanur
2016-12-09 22:42 ` Francois Romieu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox