From: Martin KaFai Lau <kafai@fb.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: <netdev@vger.kernel.org>, Saeed Mahameed <saeedm@mellanox.com>,
Tariq Toukan <tariqt@mellanox.com>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP
Date: Tue, 10 Jan 2017 09:39:27 -0800 [thread overview]
Message-ID: <20170110173927.GA75802@kafai-mba.local> (raw)
In-Reply-To: <2e26d5f0-fed8-a2b9-392a-87da29c38758@cogentembedded.com>
On Tue, Jan 10, 2017 at 03:43:39PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 01/10/2017 01:13 AM, Martin KaFai Lau wrote:
>
> >In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
> >it changed ENOTSUPP to EOPNOTSUPP by mistake. This patch fixes it.
>
> You mean vice versa (looking at your patch)?
Indeed. Will send v2 to correct this.
>
> >Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
> >Signed-off-by: Martin KaFai Lau <kafai@fb.com>
> >---
> > drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> >index edbe200ac2fa..4910d9af1933 100644
> >--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> >+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> >@@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)
> >
> > if (priv->tx_ring_num[TX_XDP] &&
> > !mlx4_en_check_xdp_mtu(dev, new_mtu))
> >- return -ENOTSUPP;
> >+ return -EOPNOTSUPP;
> >
> > dev->mtu = new_mtu;
> >
>
> MBR, Sergei
>
prev parent reply other threads:[~2017-01-10 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 22:13 [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP Martin KaFai Lau
2017-01-10 12:43 ` Sergei Shtylyov
2017-01-10 17:39 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110173927.GA75802@kafai-mba.local \
--to=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox