* [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP
@ 2017-01-09 22:13 Martin KaFai Lau
2017-01-10 12:43 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Martin KaFai Lau @ 2017-01-09 22:13 UTC (permalink / raw)
To: netdev; +Cc: Saeed Mahameed, Tariq Toukan, Kernel Team
In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
it changed ENOTSUPP to EOPNOTSUPP by mistake. This patch fixes it.
Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
Signed-off-by: Martin KaFai Lau <kafai@fb.com>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index edbe200ac2fa..4910d9af1933 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)
if (priv->tx_ring_num[TX_XDP] &&
!mlx4_en_check_xdp_mtu(dev, new_mtu))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
dev->mtu = new_mtu;
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP
2017-01-09 22:13 [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP Martin KaFai Lau
@ 2017-01-10 12:43 ` Sergei Shtylyov
2017-01-10 17:39 ` Martin KaFai Lau
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2017-01-10 12:43 UTC (permalink / raw)
To: Martin KaFai Lau, netdev; +Cc: Saeed Mahameed, Tariq Toukan, Kernel Team
Hello!
On 01/10/2017 01:13 AM, Martin KaFai Lau wrote:
> In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
> it changed ENOTSUPP to EOPNOTSUPP by mistake. This patch fixes it.
You mean vice versa (looking at your patch)?
> Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
> Signed-off-by: Martin KaFai Lau <kafai@fb.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> index edbe200ac2fa..4910d9af1933 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> @@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)
>
> if (priv->tx_ring_num[TX_XDP] &&
> !mlx4_en_check_xdp_mtu(dev, new_mtu))
> - return -ENOTSUPP;
> + return -EOPNOTSUPP;
>
> dev->mtu = new_mtu;
>
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP
2017-01-10 12:43 ` Sergei Shtylyov
@ 2017-01-10 17:39 ` Martin KaFai Lau
0 siblings, 0 replies; 3+ messages in thread
From: Martin KaFai Lau @ 2017-01-10 17:39 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, Saeed Mahameed, Tariq Toukan, Kernel Team
On Tue, Jan 10, 2017 at 03:43:39PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 01/10/2017 01:13 AM, Martin KaFai Lau wrote:
>
> >In commit b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs"),
> >it changed ENOTSUPP to EOPNOTSUPP by mistake. This patch fixes it.
>
> You mean vice versa (looking at your patch)?
Indeed. Will send v2 to correct this.
>
> >Fixes: b45f0674b997 ("mlx4: xdp: Allow raising MTU up to one page minus eth and vlan hdrs")
> >Signed-off-by: Martin KaFai Lau <kafai@fb.com>
> >---
> > drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> >index edbe200ac2fa..4910d9af1933 100644
> >--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> >+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> >@@ -2277,7 +2277,7 @@ static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)
> >
> > if (priv->tx_ring_num[TX_XDP] &&
> > !mlx4_en_check_xdp_mtu(dev, new_mtu))
> >- return -ENOTSUPP;
> >+ return -EOPNOTSUPP;
> >
> > dev->mtu = new_mtu;
> >
>
> MBR, Sergei
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-10 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-09 22:13 [PATCH net] mlx4: Return EOPNOTSUPP instead of ENOTSUPP Martin KaFai Lau
2017-01-10 12:43 ` Sergei Shtylyov
2017-01-10 17:39 ` Martin KaFai Lau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox