From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: rshearma@brocade.com, netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net] lwtunnel: fix autoload of lwt modules
Date: Tue, 17 Jan 2017 15:38:46 -0500 (EST) [thread overview]
Message-ID: <20170117.153846.1832359427601278475.davem@davemloft.net> (raw)
In-Reply-To: <54cf1176-5131-c0a0-572e-47feda7e07a9@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Tue, 17 Jan 2017 11:04:35 -0700
> handling restart for all code paths seems a bit risky for
> 4.10. Perhaps then the best course for 4.10 and older stable
> releases is to remove the autoload code from lwtunnel. It can be
> re-added once the recovery path is handled.
Indeed, we would need to handle the restart rather far up in the call chain
above where the newroute message gets processed.
But, that being said, I don't think we can legitimately just remove the
autoload functionality. It's been there for close to a full year and
I guarantee people will get burned if we take it away.
We have to find a way to fix this.
next prev parent reply other threads:[~2017-01-17 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 5:33 [PATCH net] lwtunnel: fix autoload of lwt modules David Ahern
2017-01-17 10:04 ` Robert Shearman
2017-01-17 17:07 ` David Ahern
2017-01-17 17:26 ` Robert Shearman
2017-01-17 18:04 ` David Ahern
2017-01-17 20:38 ` David Miller [this message]
2017-01-17 20:46 ` David Ahern
2017-01-17 20:54 ` David Miller
2017-01-17 23:16 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117.153846.1832359427601278475.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox