From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: rshearma@brocade.com, netdev@vger.kernel.org, roopa@cumulusnetworks.com
Subject: Re: [PATCH net] lwtunnel: fix autoload of lwt modules
Date: Tue, 17 Jan 2017 15:54:24 -0500 (EST) [thread overview]
Message-ID: <20170117.155424.1815351091063210993.davem@davemloft.net> (raw)
In-Reply-To: <7655b85f-4c03-7f08-315c-b6a99a1631f0@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Tue, 17 Jan 2017 13:46:22 -0700
> In short seems like removing the dev + the current patch dropping
> the lock fixes the current deadlock problem and should be fine.
What about the state recorded by fib_get_nhs() and similar? There is
a mapping from ifindex to ->nh_dev which would be invalidated if the
RTNL semaphore is dropped.
It won't get updated by device events, which is what normally happens,
because the fib_info is not in any of the fib_trie tables yet.
So I think you still have a huge problem without doing proper restarts.
next prev parent reply other threads:[~2017-01-17 21:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 5:33 [PATCH net] lwtunnel: fix autoload of lwt modules David Ahern
2017-01-17 10:04 ` Robert Shearman
2017-01-17 17:07 ` David Ahern
2017-01-17 17:26 ` Robert Shearman
2017-01-17 18:04 ` David Ahern
2017-01-17 20:38 ` David Miller
2017-01-17 20:46 ` David Ahern
2017-01-17 20:54 ` David Miller [this message]
2017-01-17 23:16 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117.155424.1815351091063210993.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox