Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, jonas.gorski@gmail.com, dgcbueu@gmail.com
Subject: Re: [PATCH net] net: phy: bcm63xx: Utilize correct config_intr function
Date: Wed, 18 Jan 2017 16:57:03 -0500 (EST)	[thread overview]
Message-ID: <20170118.165703.784321123769576826.davem@davemloft.net> (raw)
In-Reply-To: <20170118002655.6865-1-f.fainelli@gmail.com>

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 17 Jan 2017 16:26:55 -0800

> From: Daniel Gonzalez Cabanelas <dgcbueu@gmail.com>
> 
> Commit a1cba5613edf ("net: phy: Add Broadcom phy library for common
> interfaces") make the BCM63xx PHY driver utilize bcm_phy_config_intr()
> which would appear to do the right thing, except that it does not write
> to the MII_BCM63XX_IR register but to MII_BCM54XX_ECR which is
> different.
> 
> This would be causing invalid link parameters and events from being
> generated by the PHY interrupt.
> 
> Fixes: a1cba5613edf ("net: phy: Add Broadcom phy library for common interfaces")
> Signed-off-by: Daniel Gonzalez Cabanelas <dgcbueu@gmail.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied and queued up for -stable, thanks!

      reply	other threads:[~2017-01-18 21:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18  0:26 [PATCH net] net: phy: bcm63xx: Utilize correct config_intr function Florian Fainelli
2017-01-18 21:57 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118.165703.784321123769576826.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dgcbueu@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox