Netdev List
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Mathias Nyman <m.nyman@iki.fi>
Cc: netdev@vger.kernel.org,
	Yegor Yefremov <yegorslists@googlemail.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/1] color: use "light" colors for dark background
Date: Mon, 27 Feb 2017 09:57:45 +0100	[thread overview]
Message-ID: <20170227085745.oee6pvidb7j52cmm@dell5510> (raw)
In-Reply-To: <20170225172958.GA26279@iki.fi>

Hi,

> Yea, I admit, the original color palette is kind of horrendous. I
> wouldn't say the current colors are suitable for a light background
> either.

> I propose you just replace the current colors with their bold
> variants, and leave the background hue guessing out all together. That
> would be an all-round improvement for everyone.
Well, I agree that original colors aren't the best ones for a light background either, but
not all bold variants are suitable for light background - yellow, white and cyan are
problematic at least on some terminals with light background (e.g. konsole; white isn't
used). So I'd really keep separate sets of colors.

> I'll include some comments on this patch-set anyway, as I had a look
> at it.
Thanks for your review, I'll post fixed version with two sets of colors.


Kind regards,
Petr

      reply	other threads:[~2017-02-27  9:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 10:13 [PATCH 1/1] color: use "light" colors for dark background Petr Vorel
2017-02-24 15:28 ` David Miller
2017-02-24 16:11   ` Johannes Berg
2017-02-24 16:22     ` David Miller
2017-02-24 16:50       ` Stephen Hemminger
2017-02-24 18:29 ` Stephen Hemminger
2017-02-27  7:55   ` Petr Vorel
2017-02-25 17:29 ` Mathias Nyman
2017-02-27  8:57   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227085745.oee6pvidb7j52cmm@dell5510 \
    --to=pvorel@suse.cz \
    --cc=m.nyman@iki.fi \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox