* [PATCH net] ipv6: sr: fix double free of skb after handling invalid SRH
@ 2017-04-19 14:10 David Lebrun
2017-04-21 17:17 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David Lebrun @ 2017-04-19 14:10 UTC (permalink / raw)
To: netdev; +Cc: David Lebrun, Dan Carpenter
The icmpv6_param_prob() function already does a kfree_skb(),
this patch removes the duplicate one.
Fixes: 1ababeba4a21f3dba3da3523c670b207fb2feb62 ("ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Lebrun <david.lebrun@uclouvain.be>
---
net/ipv6/exthdrs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c
index 275cac6..25192a3 100644
--- a/net/ipv6/exthdrs.c
+++ b/net/ipv6/exthdrs.c
@@ -388,7 +388,6 @@ static int ipv6_srh_rcv(struct sk_buff *skb)
icmpv6_param_prob(skb, ICMPV6_HDR_FIELD,
((&hdr->segments_left) -
skb_network_header(skb)));
- kfree_skb(skb);
return -1;
}
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] ipv6: sr: fix double free of skb after handling invalid SRH
2017-04-19 14:10 [PATCH net] ipv6: sr: fix double free of skb after handling invalid SRH David Lebrun
@ 2017-04-21 17:17 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-04-21 17:17 UTC (permalink / raw)
To: david.lebrun; +Cc: netdev, dan.carpenter
From: David Lebrun <david.lebrun@uclouvain.be>
Date: Wed, 19 Apr 2017 16:10:19 +0200
> The icmpv6_param_prob() function already does a kfree_skb(),
> this patch removes the duplicate one.
>
> Fixes: 1ababeba4a21f3dba3da3523c670b207fb2feb62 ("ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: David Lebrun <david.lebrun@uclouvain.be>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-21 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-19 14:10 [PATCH net] ipv6: sr: fix double free of skb after handling invalid SRH David Lebrun
2017-04-21 17:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox