From: Andrew Lunn <andrew@lunn.ch>
To: Woojung.Huh@microchip.com
Cc: f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com,
netdev@vger.kernel.org, davem@davemloft.net,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support
Date: Mon, 8 May 2017 02:12:07 +0200 [thread overview]
Message-ID: <20170508001207.GE27709@lunn.ch> (raw)
In-Reply-To: <9235D6609DB808459E95D78E17F2E43D40A5C2CA@CHN-SV-EXMX02.mchp-main.com>
On Sun, May 07, 2017 at 01:02:31AM +0000, Woojung.Huh@microchip.com wrote:
> >> +}, {
> >> + .phy_id = PHY_ID_KSZ9477,
> >> + .phy_id_mask = MICREL_PHY_ID_MASK,
> >> + .name = "Microchip KSZ9477",
> >> + .features = PHY_GBIT_FEATURES,
> >> + .flags = PHY_HAS_MAGICANEG,
> >
> >Is this magic still used anywhere? I could not find anything.
> >
> Hi Andrew,
>
> Really no usage in define and flags.
> Will double check and remove it.
Hi Woojung
I just created a patch to remove PHY_HAS_MAGICANEG from the kernel.
Once net-next has reopened when the merge window closes, i will submit
it. So please don't add it here.
Thanks
Andrew
next prev parent reply other threads:[~2017-05-08 0:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 23:17 [PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support Woojung.Huh
2017-05-06 3:50 ` Andrew Lunn
2017-05-07 1:02 ` Woojung.Huh
2017-05-08 0:12 ` Andrew Lunn [this message]
2017-05-08 13:31 ` Woojung.Huh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508001207.GE27709@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox