[PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Woojung.Huh]

From: Woojung Huh <Woojung.Huh@microchip.com>

Adding Microchip 9477 Phy included in KSZ9477 Switch.

Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
---
 drivers/net/phy/micrel.c   | 12 ++++++++++++
 include/linux/micrel_phy.h |  2 ++
 2 files changed, 14 insertions(+)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 6a5fd18..65520990 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -20,6 +20,7 @@
  *			   ksz8081, ksz8091,
  *			   ksz8061,
  *		Switch : ksz8873, ksz886x
+ *			 ksz9477
  */
 
 #include <linux/kernel.h>
@@ -997,6 +998,17 @@ static struct phy_driver ksphy_driver[] = {
 	.read_status	= ksz8873mll_read_status,
 	.suspend	= genphy_suspend,
 	.resume		= genphy_resume,
+}, {
+	.phy_id		= PHY_ID_KSZ9477,
+	.phy_id_mask	= MICREL_PHY_ID_MASK,
+	.name		= "Microchip KSZ9477",
+	.features	= PHY_GBIT_FEATURES,
+	.flags		= PHY_HAS_MAGICANEG,
+	.config_init	= kszphy_config_init,
+	.config_aneg	= genphy_config_aneg,
+	.read_status	= genphy_read_status,
+	.suspend	= genphy_suspend,
+	.resume		= genphy_resume,
 } };
 
 module_phy_driver(ksphy_driver);
diff --git a/include/linux/micrel_phy.h b/include/linux/micrel_phy.h
index f541da6..472fa4d 100644
--- a/include/linux/micrel_phy.h
+++ b/include/linux/micrel_phy.h
@@ -37,6 +37,8 @@
 
 #define PHY_ID_KSZ8795		0x00221550
 
+#define	PHY_ID_KSZ9477		0x00221631
+
 /* struct phy_device dev_flags definitions */
 #define MICREL_PHY_50MHZ_CLK	0x00000001
 #define MICREL_PHY_FXEN		0x00000002
-- 
2.7.4

Re: [PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Andrew Lunn]

> +}, {
> +	.phy_id		= PHY_ID_KSZ9477,
> +	.phy_id_mask	= MICREL_PHY_ID_MASK,
> +	.name		= "Microchip KSZ9477",
> +	.features	= PHY_GBIT_FEATURES,
> +	.flags		= PHY_HAS_MAGICANEG,

Is this magic still used anywhere? I could not find anything.

   Andrew

RE: [PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Woojung.Huh]

>> +}, {
>> +     .phy_id         = PHY_ID_KSZ9477,
>> +     .phy_id_mask    = MICREL_PHY_ID_MASK,
>> +     .name           = "Microchip KSZ9477",
>> +     .features       = PHY_GBIT_FEATURES,
>> +     .flags          = PHY_HAS_MAGICANEG,
>
>Is this magic still used anywhere? I could not find anything.
>
Hi Andrew,

Really no usage in define and flags.
Will double check and remove it.

- Woojung

Re: [PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Andrew Lunn]

On Sun, May 07, 2017 at 01:02:31AM +0000, Woojung.Huh@microchip.com wrote:
> >> +}, {
> >> +     .phy_id         = PHY_ID_KSZ9477,
> >> +     .phy_id_mask    = MICREL_PHY_ID_MASK,
> >> +     .name           = "Microchip KSZ9477",
> >> +     .features       = PHY_GBIT_FEATURES,
> >> +     .flags          = PHY_HAS_MAGICANEG,
> >
> >Is this magic still used anywhere? I could not find anything.
> >
> Hi Andrew,
> 
> Really no usage in define and flags.
> Will double check and remove it.

Hi Woojung

I just created a patch to remove PHY_HAS_MAGICANEG from the kernel.
Once net-next has reopened when the merge window closes, i will submit
it. So please don't add it here.

    Thanks
	Andrew

RE: [PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Woojung.Huh]

> > >> +}, {
> > >> +     .phy_id         = PHY_ID_KSZ9477,
> > >> +     .phy_id_mask    = MICREL_PHY_ID_MASK,
> > >> +     .name           = "Microchip KSZ9477",
> > >> +     .features       = PHY_GBIT_FEATURES,
> > >> +     .flags          = PHY_HAS_MAGICANEG,
> > >
> > >Is this magic still used anywhere? I could not find anything.
> > >
> > Hi Andrew,
> >
> > Really no usage in define and flags.
> > Will double check and remove it.
> 
> Hi Woojung
> 
> I just created a patch to remove PHY_HAS_MAGICANEG from the kernel.
> Once net-next has reopened when the merge window closes, i will submit
> it. So please don't add it here.
Hi Andrew,

Thanks you. I'll remove it.

Woojung