From: Yuval Shaia <yuval.shaia@oracle.com>
To: davem@davemloft.net, jarod@redhat.com, yuval.shaia@oracle.com,
tklauser@distanz.ch, tremyfr@gmail.com, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org
Subject: [PATCH] net/dec: Make __de_get_link_ksettings return void
Date: Sun, 4 Jun 2017 20:08:51 +0300 [thread overview]
Message-ID: <20170604170851.3808-1-yuval.shaia@oracle.com> (raw)
Make return value void since function never return meaningfull value
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
drivers/net/ethernet/dec/tulip/de2104x.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
index 91b8f6f..c87b8cc 100644
--- a/drivers/net/ethernet/dec/tulip/de2104x.c
+++ b/drivers/net/ethernet/dec/tulip/de2104x.c
@@ -1483,8 +1483,8 @@ static void __de_get_regs(struct de_private *de, u8 *buf)
de_rx_missed(de, rbuf[8]);
}
-static int __de_get_link_ksettings(struct de_private *de,
- struct ethtool_link_ksettings *cmd)
+static void __de_get_link_ksettings(struct de_private *de,
+ struct ethtool_link_ksettings *cmd)
{
ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.supported,
de->media_supported);
@@ -1517,8 +1517,6 @@ static int __de_get_link_ksettings(struct de_private *de,
cmd->base.autoneg = AUTONEG_ENABLE;
/* ignore maxtxpkt, maxrxpkt for now */
next reply other threads:[~2017-06-04 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 17:08 Yuval Shaia [this message]
2017-06-04 17:22 ` [PATCH] net/dec: Make __de_get_link_ksettings return void Sergei Shtylyov
2017-06-04 17:24 ` Sergei Shtylyov
2017-06-04 19:52 ` Yuval Shaia
2017-06-05 15:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604170851.3808-1-yuval.shaia@oracle.com \
--to=yuval.shaia@oracle.com \
--cc=davem@davemloft.net \
--cc=jarod@redhat.com \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox