From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yuval Shaia <yuval.shaia@oracle.com>,
davem@davemloft.net, jarod@redhat.com, tklauser@distanz.ch,
tremyfr@gmail.com, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH] net/dec: Make __de_get_link_ksettings return void
Date: Sun, 4 Jun 2017 20:24:09 +0300 [thread overview]
Message-ID: <9bda442b-ef4b-0888-1717-241671375bce@cogentembedded.com> (raw)
In-Reply-To: <4391c380-f7f6-d549-a225-716b9b9df664@cogentembedded.com>
On 6/4/2017 8:22 PM, Sergei Shtylyov wrote:
>> Make return value void since function never return meaningfull value
>
> You only make 1 of 2 functions void. It looks like there should be 2 patches.
Oh, sorry, I was just blind. B-)
MBR, Sergei
next prev parent reply other threads:[~2017-06-04 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 17:08 [PATCH] net/dec: Make __de_get_link_ksettings return void Yuval Shaia
2017-06-04 17:22 ` Sergei Shtylyov
2017-06-04 17:24 ` Sergei Shtylyov [this message]
2017-06-04 19:52 ` Yuval Shaia
2017-06-05 15:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bda442b-ef4b-0888-1717-241671375bce@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=jarod@redhat.com \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
--cc=tremyfr@gmail.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox