ravb WoL interrupt flood

ravb WoL interrupt flood

[Geert Uytterhoeven]

Hi Niklas,

I just got a flood of messages after WoL from s2idle on r8a7795/salvator-x:

[  802.341060] ravb e6800000.ethernet eth0: ignoring interrupt, rx
status 0x00000001, rx mask 0x00000001,
[  802.350369] ravb e6800000.ethernet eth0:                     tx
status 0x00000000, tx mask 0x00000001.
[  802.359684] ravb e6800000.ethernet eth0: ignoring interrupt, rx
status 0x00000001, rx mask 0x00000001,
[  802.368993] ravb e6800000.ethernet eth0:                     tx
status 0x00000000, tx mask 0x00000001.
[  802.378308] ravb e6800000.ethernet eth0: ignoring interrupt, rx
status 0x00000001, rx mask 0x00000001,
[  802.387616] ravb e6800000.ethernet eth0:                     tx
status 0x00000000, tx mask 0x00000001.
[  802.396931] ravb e6800000.ethernet eth0: ignoring interrupt, rx
status 0x00000001, rx mask 0x00000001,
[  802.406240] ravb e6800000.ethernet eth0:                     tx
status 0x00000000, tx mask 0x00000001.
...

Unfortunately I cannot reproduce it.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: ravb WoL interrupt flood

[Niklas Söderlund]

Hi Geert,

Thanks for the report. I did run a 200+ loop suspend/resume without 
issues so this error is probably hard to reproduce or something changed 
since v4.11-rc1 which if IIRC was the base I used to do the tests.

All I can think of is that if the interface was down at the time the 
system was suspend. There is a bug in  the driver which is in 
renesas-drivers related to that. But given that you woken up by WoL that 
is probably not the case :-)

I will do more tests and see if I can reproduce this once I'm back in 
Stockholm.


On 2017-05-30 11:23:23 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
> 
> I just got a flood of messages after WoL from s2idle on r8a7795/salvator-x:
> 
> [  802.341060] ravb e6800000.ethernet eth0: ignoring interrupt, rx
> status 0x00000001, rx mask 0x00000001,
> [  802.350369] ravb e6800000.ethernet eth0:                     tx
> status 0x00000000, tx mask 0x00000001.
> [  802.359684] ravb e6800000.ethernet eth0: ignoring interrupt, rx
> status 0x00000001, rx mask 0x00000001,
> [  802.368993] ravb e6800000.ethernet eth0:                     tx
> status 0x00000000, tx mask 0x00000001.
> [  802.378308] ravb e6800000.ethernet eth0: ignoring interrupt, rx
> status 0x00000001, rx mask 0x00000001,
> [  802.387616] ravb e6800000.ethernet eth0:                     tx
> status 0x00000000, tx mask 0x00000001.
> [  802.396931] ravb e6800000.ethernet eth0: ignoring interrupt, rx
> status 0x00000001, rx mask 0x00000001,
> [  802.406240] ravb e6800000.ethernet eth0:                     tx
> status 0x00000000, tx mask 0x00000001.
> ...
> 
> Unfortunately I cannot reproduce it.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Regards,
Niklas Söderlund

Re: ravb WoL interrupt flood

[Niklas Söderlund]

Hi Geert,

On 2017-05-30 12:29:24 +0200, Niklas Söderlund wrote:
> Hi Geert,
> 
> Thanks for the report. I did run a 200+ loop suspend/resume without 
> issues so this error is probably hard to reproduce or something changed 
> since v4.11-rc1 which if IIRC was the base I used to do the tests.
> 
> All I can think of is that if the interface was down at the time the 
> system was suspend. There is a bug in  the driver which is in 
> renesas-drivers related to that. But given that you woken up by WoL that 
> is probably not the case :-)
> 
> I will do more tests and see if I can reproduce this once I'm back in 
> Stockholm.

I have now done over a 500 suspend/resume loops and not been able to see 
this :-(

I have run it with and without your '[PATCH/RFC] clk: renesas: cpg-mssr: 
Restore module clock registers during resume' patch but no noticeable 
difference.

I had a small cleanup in my patch which would differ from the one you 
use. The diff is only in effect when resuming from s2ram so it should 
have no effect here but still it is a change. My plan is to submit the 
version with this fix for tomorrows renesas-drivers and then rerun my 
tests using that. If I still can't reproduce it then I think I will 
submit a v2 of my WoL patch to the ML, do this sounds like an OK plan to 
you?

> 
> 
> On 2017-05-30 11:23:23 +0200, Geert Uytterhoeven wrote:
> > Hi Niklas,
> > 
> > I just got a flood of messages after WoL from s2idle on r8a7795/salvator-x:
> > 
> > [  802.341060] ravb e6800000.ethernet eth0: ignoring interrupt, rx
> > status 0x00000001, rx mask 0x00000001,
> > [  802.350369] ravb e6800000.ethernet eth0:                     tx
> > status 0x00000000, tx mask 0x00000001.
> > [  802.359684] ravb e6800000.ethernet eth0: ignoring interrupt, rx
> > status 0x00000001, rx mask 0x00000001,
> > [  802.368993] ravb e6800000.ethernet eth0:                     tx
> > status 0x00000000, tx mask 0x00000001.
> > [  802.378308] ravb e6800000.ethernet eth0: ignoring interrupt, rx
> > status 0x00000001, rx mask 0x00000001,
> > [  802.387616] ravb e6800000.ethernet eth0:                     tx
> > status 0x00000000, tx mask 0x00000001.
> > [  802.396931] ravb e6800000.ethernet eth0: ignoring interrupt, rx
> > status 0x00000001, rx mask 0x00000001,
> > [  802.406240] ravb e6800000.ethernet eth0:                     tx
> > status 0x00000000, tx mask 0x00000001.
> > ...
> > 
> > Unfortunately I cannot reproduce it.
> > 
> > Gr{oetje,eeting}s,
> > 
> >                         Geert
> > 
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> > 
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds
> 
> -- 
> Regards,
> Niklas Söderlund

-- 
Regards,
Niklas Söderlund