* mlx5 still has lots of warnings
@ 2017-07-24 16:51 Stephen Hemminger
2017-07-26 11:27 ` Saeed Mahameed
2017-07-27 10:55 ` Saeed Mahameed
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2017-07-24 16:51 UTC (permalink / raw)
To: Saeed Mahameed; +Cc: netdev
I sent patches for this, and you said you were going to solve this (back in April).
Still see lots of warnings from MLX5.
CC [M] drivers/net/ethernet/mellanox/mlx5/core/en_rep.o
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:767:35: warning: ‘mlx5e_rep_switchdev_ops’ defined but not used [-Wunused-const-variable=]
static const struct switchdev_ops mlx5e_rep_switchdev_ops = {
^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:41:0:
drivers/net/ethernet/mellanox/mlx5/core/en.h:188:19: warning: ‘mlx5e_priv_flags’ defined but not used [-Wunused-const-variable=]
static const char mlx5e_priv_flags[][ETH_GSTRING_LEN] = {
^~~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/mellanox/mlx5/core/en.h:51:0,
from drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:41:
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:427:34: warning: ‘mlx5e_pme_error_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc mlx5e_pme_error_desc[] = {
^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:423:34: warning: ‘mlx5e_pme_status_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc mlx5e_pme_status_desc[] = {
^~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:372:34: warning: ‘sq_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc sq_stats_desc[] = {
^~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:331:34: warning: ‘rq_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc rq_stats_desc[] = {
^~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:303:34: warning: ‘pcie_perf_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc pcie_perf_stats_desc[] = {
^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:284:34: warning: ‘pport_per_prio_pfc_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc pport_per_prio_pfc_stats_desc[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:277:34: warning: ‘pport_per_prio_traffic_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc pport_per_prio_traffic_stats_desc[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:272:34: warning: ‘pport_phy_statistical_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc pport_phy_statistical_stats_desc[] = {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:256:34: warning: ‘pport_2819_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc pport_2819_stats_desc[] = {
^~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:250:34: warning: ‘pport_2863_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc pport_2863_stats_desc[] = {
^~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:229:34: warning: ‘pport_802_3_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc pport_802_3_stats_desc[] = {
^~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:145:34: warning: ‘vport_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc vport_stats_desc[] = {
^~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:133:34: warning: ‘q_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc q_stats_desc[] = {
^~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:92:34: warning: ‘sw_stats_desc’ defined but not used [-Wunused-const-variable=]
static const struct counter_desc sw_stats_desc[] = {
^~~~~~~~~~~~~
LD [M] drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.o
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mlx5 still has lots of warnings
2017-07-24 16:51 mlx5 still has lots of warnings Stephen Hemminger
@ 2017-07-26 11:27 ` Saeed Mahameed
2017-07-27 10:55 ` Saeed Mahameed
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2017-07-26 11:27 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Linux Netdev List
On Mon, Jul 24, 2017 at 7:51 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> I sent patches for this, and you said you were going to solve this (back in April).
> Still see lots of warnings from MLX5.
>
Hi Stephen,
You are right, we were planning to do some code refactoring to this
area and the priority of this task got reduced.
I will handle this myself, I will take your original patch if required.
Thanks for the reminder.
> CC [M] drivers/net/ethernet/mellanox/mlx5/core/en_rep.o
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:767:35: warning: ‘mlx5e_rep_switchdev_ops’ defined but not used [-Wunused-const-variable=]
> static const struct switchdev_ops mlx5e_rep_switchdev_ops = {
> ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:41:0:
> drivers/net/ethernet/mellanox/mlx5/core/en.h:188:19: warning: ‘mlx5e_priv_flags’ defined but not used [-Wunused-const-variable=]
> static const char mlx5e_priv_flags[][ETH_GSTRING_LEN] = {
> ^~~~~~~~~~~~~~~~
> In file included from drivers/net/ethernet/mellanox/mlx5/core/en.h:51:0,
> from drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:41:
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:427:34: warning: ‘mlx5e_pme_error_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc mlx5e_pme_error_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:423:34: warning: ‘mlx5e_pme_status_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc mlx5e_pme_status_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:372:34: warning: ‘sq_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc sq_stats_desc[] = {
> ^~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:331:34: warning: ‘rq_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc rq_stats_desc[] = {
> ^~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:303:34: warning: ‘pcie_perf_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pcie_perf_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:284:34: warning: ‘pport_per_prio_pfc_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_per_prio_pfc_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:277:34: warning: ‘pport_per_prio_traffic_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_per_prio_traffic_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:272:34: warning: ‘pport_phy_statistical_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_phy_statistical_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:256:34: warning: ‘pport_2819_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_2819_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:250:34: warning: ‘pport_2863_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_2863_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:229:34: warning: ‘pport_802_3_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_802_3_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:145:34: warning: ‘vport_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc vport_stats_desc[] = {
> ^~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:133:34: warning: ‘q_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc q_stats_desc[] = {
> ^~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:92:34: warning: ‘sw_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc sw_stats_desc[] = {
> ^~~~~~~~~~~~~
> LD [M] drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.o
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mlx5 still has lots of warnings
2017-07-24 16:51 mlx5 still has lots of warnings Stephen Hemminger
2017-07-26 11:27 ` Saeed Mahameed
@ 2017-07-27 10:55 ` Saeed Mahameed
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2017-07-27 10:55 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Linux Netdev List
On Mon, Jul 24, 2017 at 7:51 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> I sent patches for this, and you said you were going to solve this (back in April).
> Still see lots of warnings from MLX5.
>
Hi Stephen,
What gcc version are you using ? what special Cflags to use?
I am failing to see the below warning with "-Wall" and gcc 5.4 at least.
> CC [M] drivers/net/ethernet/mellanox/mlx5/core/en_rep.o
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:767:35: warning: ‘mlx5e_rep_switchdev_ops’ defined but not used [-Wunused-const-variable=]
> static const struct switchdev_ops mlx5e_rep_switchdev_ops = {
> ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:41:0:
> drivers/net/ethernet/mellanox/mlx5/core/en.h:188:19: warning: ‘mlx5e_priv_flags’ defined but not used [-Wunused-const-variable=]
> static const char mlx5e_priv_flags[][ETH_GSTRING_LEN] = {
> ^~~~~~~~~~~~~~~~
> In file included from drivers/net/ethernet/mellanox/mlx5/core/en.h:51:0,
> from drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:41:
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:427:34: warning: ‘mlx5e_pme_error_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc mlx5e_pme_error_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:423:34: warning: ‘mlx5e_pme_status_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc mlx5e_pme_status_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:372:34: warning: ‘sq_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc sq_stats_desc[] = {
> ^~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:331:34: warning: ‘rq_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc rq_stats_desc[] = {
> ^~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:303:34: warning: ‘pcie_perf_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pcie_perf_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:284:34: warning: ‘pport_per_prio_pfc_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_per_prio_pfc_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:277:34: warning: ‘pport_per_prio_traffic_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_per_prio_traffic_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:272:34: warning: ‘pport_phy_statistical_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_phy_statistical_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:256:34: warning: ‘pport_2819_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_2819_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:250:34: warning: ‘pport_2863_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_2863_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:229:34: warning: ‘pport_802_3_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc pport_802_3_stats_desc[] = {
> ^~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:145:34: warning: ‘vport_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc vport_stats_desc[] = {
> ^~~~~~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:133:34: warning: ‘q_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc q_stats_desc[] = {
> ^~~~~~~~~~~~
> drivers/net/ethernet/mellanox/mlx5/core/en_stats.h:92:34: warning: ‘sw_stats_desc’ defined but not used [-Wunused-const-variable=]
> static const struct counter_desc sw_stats_desc[] = {
> ^~~~~~~~~~~~~
> LD [M] drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.o
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-27 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-24 16:51 mlx5 still has lots of warnings Stephen Hemminger
2017-07-26 11:27 ` Saeed Mahameed
2017-07-27 10:55 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox