From: Stephen Hemminger <stephen@networkplumber.org>
To: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com
Cc: devel@linuxdriverproject.org, netdev@vger.kernel.org
Subject: [PATCH net-next 02/10] netvsc: don't signal host twice if empty
Date: Wed, 9 Aug 2017 17:46:04 -0700 [thread overview]
Message-ID: <20170810004612.22163-3-sthemmin@microsoft.com> (raw)
In-Reply-To: <20170810004612.22163-1-sthemmin@microsoft.com>
When hv_pkt_iter_next() returns NULL, it has already called
hv_pkt_iter_close(). Calling it twice can lead to extra host signal.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
drivers/net/hyperv/netvsc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 208f03aa83de..c842265d1df9 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -1190,10 +1190,6 @@ int netvsc_poll(struct napi_struct *napi, int budget)
nvchan->desc = hv_pkt_iter_next(channel, nvchan->desc);
}
- /* if ring is empty, signal host */
- if (!nvchan->desc)
- hv_pkt_iter_close(channel);
-
/* If send of pending receive completions suceeded
* and did not exhaust NAPI budget this time
* and not doing busy poll
--
2.11.0
next prev parent reply other threads:[~2017-08-10 0:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 0:46 [PATCH net-next 00/10] netvsc: minor fixes and improvements Stephen Hemminger
2017-08-10 0:46 ` [PATCH net-next 01/10] netvsc: delay setup of VF device Stephen Hemminger
2017-08-10 0:46 ` Stephen Hemminger [this message]
2017-08-10 0:46 ` [PATCH net-next 03/10] netvsc: propagate MAC address change to VF slave Stephen Hemminger
2017-08-10 0:46 ` [PATCH net-next 04/10] netvsc: check error return when restoring channels and mtu Stephen Hemminger
2017-08-10 0:46 ` [PATCH net-next 05/10] netvsc: no need to allocate send/receive on numa node Stephen Hemminger
2017-08-10 0:46 ` [PATCH net-next 06/10] netvsc: whitespace cleanup Stephen Hemminger
2017-08-10 0:46 ` [PATCH net-next 07/10] netvsc: remove unnecessary cast of void pointer Stephen Hemminger
2017-08-10 0:46 ` [PATCH net-next 08/10] netvsc: remove unnecessary check for NULL hdr Stephen Hemminger
2017-08-10 0:46 ` [PATCH net-next 09/10] netvsc: allow controlling send/recv buffer size Stephen Hemminger
2017-08-10 0:46 ` [PATCH net-next 10/10] netvsc: keep track of some non-fatal overload conditions Stephen Hemminger
2017-08-11 21:00 ` [PATCH net-next 00/10] netvsc: minor fixes and improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810004612.22163-3-sthemmin@microsoft.com \
--to=stephen@networkplumber.org \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox