* [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.
@ 2017-08-11 3:16 Tonghao Zhang
2017-08-11 17:43 ` Willem de Bruijn
2017-08-11 21:46 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Tonghao Zhang @ 2017-08-11 3:16 UTC (permalink / raw)
To: netdev; +Cc: Tonghao Zhang, Willem de Bruijn
Because we remove the UFO support, we will also remove the
CHECKSUM_UNNECESSARY check in skb_needs_check().
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
net/core/dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 3f69f6e..1024d37 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2731,8 +2731,7 @@ struct sk_buff *skb_mac_gso_segment(struct sk_buff *skb,
static inline bool skb_needs_check(struct sk_buff *skb, bool tx_path)
{
if (tx_path)
- return skb->ip_summed != CHECKSUM_PARTIAL &&
- skb->ip_summed != CHECKSUM_UNNECESSARY;
+ return skb->ip_summed != CHECKSUM_PARTIAL;
return skb->ip_summed == CHECKSUM_NONE;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.
2017-08-11 3:16 [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx Tonghao Zhang
@ 2017-08-11 17:43 ` Willem de Bruijn
2017-08-11 21:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2017-08-11 17:43 UTC (permalink / raw)
To: Tonghao Zhang; +Cc: Network Development, Willem de Bruijn
On Thu, Aug 10, 2017 at 8:16 PM, Tonghao Zhang <xiangxia.m.yue@gmail.com> wrote:
> Because we remove the UFO support, we will also remove the
> CHECKSUM_UNNECESSARY check in skb_needs_check().
>
> Cc: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Thanks for fixing up and resubmitting after the merge.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx.
2017-08-11 3:16 [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx Tonghao Zhang
2017-08-11 17:43 ` Willem de Bruijn
@ 2017-08-11 21:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-08-11 21:46 UTC (permalink / raw)
To: xiangxia.m.yue; +Cc: netdev, willemb
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Date: Thu, 10 Aug 2017 20:16:29 -0700
> Because we remove the UFO support, we will also remove the
> CHECKSUM_UNNECESSARY check in skb_needs_check().
>
> Cc: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-11 21:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-11 3:16 [PATCH net-next] net: skb_needs_check() removes CHECKSUM_UNNECESSARY check for tx Tonghao Zhang
2017-08-11 17:43 ` Willem de Bruijn
2017-08-11 21:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox