* [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting
@ 2017-09-07 7:11 Nisar.Sayed
2017-09-07 14:13 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Nisar.Sayed @ 2017-09-07 7:11 UTC (permalink / raw)
To: davem; +Cc: UNGLinuxDriver, netdev
From: Nisar Sayed <Nisar.Sayed@microchip.com>
Use default value loaded from EEPROM/OTP when resetting
Signed-off-by: Nisar Sayed <Nisar.Sayed@microchip.com>
---
drivers/net/usb/lan78xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 94ef943..8fd7c2f 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2452,7 +2452,6 @@ static int lan78xx_reset(struct lan78xx_net *dev)
/* LAN7801 only has RGMII mode */
if (dev->chipid == ID_REV_CHIP_ID_7801_)
buf &= ~MAC_CR_GMII_EN_;
- buf |= MAC_CR_AUTO_DUPLEX_ | MAC_CR_AUTO_SPEED_;
ret = lan78xx_write_reg(dev, MAC_CR, buf);
ret = lan78xx_read_reg(dev, MAC_TX, &buf);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting
2017-09-07 7:11 [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting Nisar.Sayed
@ 2017-09-07 14:13 ` Andrew Lunn
2017-09-08 9:11 ` Nisar.Sayed
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2017-09-07 14:13 UTC (permalink / raw)
To: Nisar.Sayed; +Cc: davem, UNGLinuxDriver, netdev
On Thu, Sep 07, 2017 at 07:11:50AM +0000, Nisar.Sayed@microchip.com wrote:
> From: Nisar Sayed <Nisar.Sayed@microchip.com>
>
> Use default value loaded from EEPROM/OTP when resetting
Hi Nisar
Subject: [PATCH 3/3]
Is this a fix for net, or further development for net-next?
Why do we want the default values?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting
2017-09-07 14:13 ` Andrew Lunn
@ 2017-09-08 9:11 ` Nisar.Sayed
0 siblings, 0 replies; 3+ messages in thread
From: Nisar.Sayed @ 2017-09-08 9:11 UTC (permalink / raw)
To: andrew; +Cc: davem, UNGLinuxDriver, netdev
> On Thu, Sep 07, 2017 at 07:11:50AM +0000, Nisar.Sayed@microchip.com
> wrote:
> > From: Nisar Sayed <Nisar.Sayed@microchip.com>
> >
> > Use default value loaded from EEPROM/OTP when resetting
>
> Hi Nisar
>
> Subject: [PATCH 3/3]
>
> Is this a fix for net, or further development for net-next?
>
> Why do we want the default values?
>
> Andrew
Thanks Andrew,
Yes it is for "net", sorry missed to include it, will update in next version of submit.
These bits are "reset protected" and should not be modified and must use the
Must be configured from EEPROM only. Will update the description.
- Nisar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-08 9:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 7:11 [PATCH 3/3] lan78xx: Use default value loaded from EEPROM/OTP when resetting Nisar.Sayed
2017-09-07 14:13 ` Andrew Lunn
2017-09-08 9:11 ` Nisar.Sayed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox