From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: siva.kallam@broadcom.com, prashant@broadcom.com,
mchan@broadcom.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tg3: clean up redundant initialization of tnapi
Date: Thu, 14 Sep 2017 10:00:41 -0700 (PDT) [thread overview]
Message-ID: <20170914.100041.1507992015904111255.davem@davemloft.net> (raw)
In-Reply-To: <20170914160125.11007-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Thu, 14 Sep 2017 17:01:25 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> tnapi is being initialized and then immediately updated and
> hence the initialiation is redundant. Clean up the warning
> by moving the declaration and initialization to the inside
> of the for-loop.
>
> Cleans up clang scan-build warning:
> warning: Value stored to 'tnapi' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2017-09-14 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 16:01 [PATCH] tg3: clean up redundant initialization of tnapi Colin King
2017-09-14 17:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914.100041.1507992015904111255.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
--cc=siva.kallam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox