* [PATCH 1/1] ipv6_skip_exthdr: use ipv6_authlen for AH header length computation
@ 2017-09-15 5:04 Xiang Gao
2017-09-18 21:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xiang Gao @ 2017-09-15 5:04 UTC (permalink / raw)
To: trivial, netdev, David S. Miller, Alexey Kuznetsov,
Hideaki YOSHIFUJI
>From 09cf2e3cf09cf591283785aaa8159baf39ac2e08 Mon Sep 17 00:00:00 2001
From: Xiang Gao <qasdfgtyuiop@gmail.com>
Date: Fri, 15 Sep 2017 00:44:12 -0400
Subject: [PATCH] ipv6_skip_exthdr: use ipv6_authlen for AH hdrlen
In ipv6_skip_exthdr, the lengh of AH header is computed manually
as (hp->hdrlen+2)<<2. However, in include/linux/ipv6.h, a macro
named ipv6_authlen is already defined for exactly the same job. This
commit replaces the manual computation code with the macro.
---
net/ipv6/exthdrs_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/exthdrs_core.c b/net/ipv6/exthdrs_core.c
index 305e2ed730bf..115d60919f72 100644
--- a/net/ipv6/exthdrs_core.c
+++ b/net/ipv6/exthdrs_core.c
@@ -99,7 +99,7 @@ int ipv6_skip_exthdr(const struct sk_buff *skb, int
start, u8 *nexthdrp,
break;
hdrlen = 8;
} else if (nexthdr == NEXTHDR_AUTH)
- hdrlen = (hp->hdrlen+2)<<2;
+ hdrlen = ipv6_authlen(hp);
else
hdrlen = ipv6_optlen(hp);
--
2.14.1
Signed-off-by: Xiang Gao <qasdfgtyuiop@gmail.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ipv6_skip_exthdr: use ipv6_authlen for AH header length computation
2017-09-15 5:04 [PATCH 1/1] ipv6_skip_exthdr: use ipv6_authlen for AH header length computation Xiang Gao
@ 2017-09-18 21:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-09-18 21:53 UTC (permalink / raw)
To: qasdfgtyuiop; +Cc: trivial, netdev, kuznet, yoshfuji
From: Xiang Gao <qasdfgtyuiop@gmail.com>
Date: Fri, 15 Sep 2017 01:04:27 -0400
> From 09cf2e3cf09cf591283785aaa8159baf39ac2e08 Mon Sep 17 00:00:00 2001
> From: Xiang Gao <qasdfgtyuiop@gmail.com>
> Date: Fri, 15 Sep 2017 00:44:12 -0400
> Subject: [PATCH] ipv6_skip_exthdr: use ipv6_authlen for AH hdrlen
>
> In ipv6_skip_exthdr, the lengh of AH header is computed manually
> as (hp->hdrlen+2)<<2. However, in include/linux/ipv6.h, a macro
> named ipv6_authlen is already defined for exactly the same job. This
> commit replaces the manual computation code with the macro.
Your patch was whitespace corrupted by your email client.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-18 21:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-15 5:04 [PATCH 1/1] ipv6_skip_exthdr: use ipv6_authlen for AH header length computation Xiang Gao
2017-09-18 21:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox