* [PATCH iproute2 1/1] ss: initialize 'fackets' member of tcpstat structure
@ 2017-10-18 19:44 Roman Mashak
2017-10-23 12:44 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Roman Mashak @ 2017-10-18 19:44 UTC (permalink / raw)
To: stephen; +Cc: jhs, netdev, Roman Mashak
'fackets' has never been initialized with kernel extracted information, thus
never really printed.
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
---
misc/ss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/misc/ss.c b/misc/ss.c
index 09bff8a..465e867 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -2226,6 +2226,7 @@ static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,
s.retrans_total = info->tcpi_total_retrans;
s.lost = info->tcpi_lost;
s.sacked = info->tcpi_sacked;
+ s.fackets = info->tcpi_fackets;
s.reordering = info->tcpi_reordering;
s.rcv_space = info->tcpi_rcv_space;
s.cwnd = info->tcpi_snd_cwnd;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2 1/1] ss: initialize 'fackets' member of tcpstat structure
2017-10-18 19:44 [PATCH iproute2 1/1] ss: initialize 'fackets' member of tcpstat structure Roman Mashak
@ 2017-10-23 12:44 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2017-10-23 12:44 UTC (permalink / raw)
To: Roman Mashak; +Cc: jhs, netdev
On Wed, 18 Oct 2017 15:44:01 -0400
Roman Mashak <mrv@mojatatu.com> wrote:
> 'fackets' has never been initialized with kernel extracted information, thus
> never really printed.
>
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Applied. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-23 12:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-18 19:44 [PATCH iproute2 1/1] ss: initialize 'fackets' member of tcpstat structure Roman Mashak
2017-10-23 12:44 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox