From: David Miller <davem@davemloft.net>
To: antoine.tenart@free-electrons.com
Cc: andrew@lunn.ch, gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com,
miquel.raynal@free-electrons.com, nadavh@marvell.com,
linux-kernel@vger.kernel.org, mw@semihalf.com,
stefanc@marvell.com, netdev@vger.kernel.org
Subject: Re: [PATCH net 2/3] net: mvpp2: do not unmap TSO headers buffers
Date: Tue, 24 Oct 2017 18:34:48 +0900 (KST) [thread overview]
Message-ID: <20171024.183448.1039880641989092213.davem@davemloft.net> (raw)
In-Reply-To: <20171023132431.5756-2-antoine.tenart@free-electrons.com>
From: Antoine Tenart <antoine.tenart@free-electrons.com>
Date: Mon, 23 Oct 2017 15:24:30 +0200
> The TSO header buffers are coming from a per cpu pool and should not
> be unmapped as they are reused. The PPv2 driver was unmapping all
> descriptors buffers unconditionally. This patch fixes this by checking
> the buffers dma addresses before unmapping them, and by not unmapping
> those who are located in the TSO header pool.
>
> Fixes: 186cd4d4e414 ("net: mvpp2: software tso support")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Applied.
next prev parent reply other threads:[~2017-10-24 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 13:24 [PATCH net 1/3] net: mvpp2: fix TSO headers allocation and management Antoine Tenart
2017-10-23 13:24 ` [PATCH net 2/3] net: mvpp2: do not unmap TSO headers buffers Antoine Tenart
2017-10-24 9:34 ` David Miller [this message]
2017-10-23 13:24 ` [PATCH net 3/3] net: mvpp2: do not call txq_done from the Tx path when Tx irqs are used Antoine Tenart
2017-10-24 9:34 ` David Miller
2017-10-24 9:34 ` [PATCH net 1/3] net: mvpp2: fix TSO headers allocation and management David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024.183448.1039880641989092213.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox