Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: antoine.tenart@free-electrons.com
Cc: andrew@lunn.ch, gregory.clement@free-electrons.com,
	thomas.petazzoni@free-electrons.com,
	miquel.raynal@free-electrons.com, nadavh@marvell.com,
	linux-kernel@vger.kernel.org, mw@semihalf.com,
	stefanc@marvell.com, netdev@vger.kernel.org
Subject: Re: [PATCH net 3/3] net: mvpp2: do not call txq_done from the Tx path when Tx irqs are used
Date: Tue, 24 Oct 2017 18:34:58 +0900 (KST)	[thread overview]
Message-ID: <20171024.183458.1613489746739108710.davem@davemloft.net> (raw)
In-Reply-To: <20171023132431.5756-3-antoine.tenart@free-electrons.com>

From: Antoine Tenart <antoine.tenart@free-electrons.com>
Date: Mon, 23 Oct 2017 15:24:31 +0200

> When Tx IRQs are used, txq_bufs_free() can be called from both the Tx
> path and from NAPI poll(). This led to CPU stalls as if these two tasks
> (Tx and Poll) are scheduled on two CPUs at the same time, DMA unmapping
> operations are done on the same txq buffers.
> 
> This patch adds a check not to call txq_done() from the Tx path if Tx
> interrupts are used as it does not make sense to do so.
> 
> Fixes: edc660fa09e2 ("net: mvpp2: replace TX coalescing interrupts with hrtimer")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>

Applied.

  reply	other threads:[~2017-10-24  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 13:24 [PATCH net 1/3] net: mvpp2: fix TSO headers allocation and management Antoine Tenart
2017-10-23 13:24 ` [PATCH net 2/3] net: mvpp2: do not unmap TSO headers buffers Antoine Tenart
2017-10-24  9:34   ` David Miller
2017-10-23 13:24 ` [PATCH net 3/3] net: mvpp2: do not call txq_done from the Tx path when Tx irqs are used Antoine Tenart
2017-10-24  9:34   ` David Miller [this message]
2017-10-24  9:34 ` [PATCH net 1/3] net: mvpp2: fix TSO headers allocation and management David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171024.183458.1613489746739108710.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@free-electrons.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox