From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tom Herbert <tom@quantonium.net>
Cc: "David S . Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Rohit LastName <rohit@quantonium.net>
Subject: Re: [PATCH net-next 2/5] rhashtable: Add rhastable_walk_peek
Date: Fri, 1 Dec 2017 12:21:02 +1100 [thread overview]
Message-ID: <20171201012102.GA26965@gondor.apana.org.au> (raw)
In-Reply-To: <CAPDqMeoWg_mvTnMJscbSWxnm4kA2h28Ggxn4zjYzTm_RccMi0g@mail.gmail.com>
On Thu, Nov 30, 2017 at 05:15:16PM -0800, Tom Herbert wrote:
>
> We don't need a guarantee of stability, but what I am seeing is that
> we're consisitently dropping entries on when doing a multi-part
> netlink walk. We start iterating over the table filling in the netlink
> info. But eventually the netlink info fills up and returns an error.
> netlink dump gets called again but now the iter of the table returns
> the object following the one that would have overflowed the netlink
> buffer. So the result I was seeing is that we dropped one object in in
> each pass.
Thanks Tom! This information is very useful.
It sounds like this problem isn't specific to ila and would exist
for all rhashtable users that dump through netlink. Let me think
about this a little bit more.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-12-01 1:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 0:03 [PATCH net-next 0/5] rhashtable: New features in walk and bucket locks Tom Herbert
2017-12-01 0:03 ` [PATCH net-next 1/5] rhashtable: Don't reset walker table in rhashtable_walk_start Tom Herbert
2017-12-01 22:18 ` Herbert Xu
2017-12-01 23:29 ` Tom Herbert
2017-12-02 1:07 ` Tom Herbert
2017-12-01 0:03 ` [PATCH net-next 2/5] rhashtable: Add rhastable_walk_peek Tom Herbert
2017-12-01 0:38 ` Herbert Xu
2017-12-01 1:15 ` Tom Herbert
2017-12-01 1:21 ` Herbert Xu [this message]
2017-12-01 3:50 ` Tom Herbert
2017-12-01 0:03 ` [PATCH net-next 3/5] rhashtable: abstract out function to get hash Tom Herbert
2017-12-01 0:03 ` [PATCH net-next 4/5] spinlock: Add library function to allocate spinlock buckets array Tom Herbert
2017-12-01 0:03 ` [PATCH net-next 5/5] rhashtable: Call library function alloc_bucket_locks Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201012102.GA26965@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rohit@quantonium.net \
--cc=tom@quantonium.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox