From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org,
ard.biesheuvel@linaro.org
Subject: Re: [PATCH net-next resubmit 1/2] net: phy: core: remove now uneeded disabling of interrupts
Date: Mon, 04 Dec 2017 10:24:17 -0500 (EST) [thread overview]
Message-ID: <20171204.102417.1919875184945871383.davem@davemloft.net> (raw)
In-Reply-To: <ba11e1ae-dc21-e036-f918-1ed44c92a424@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 30 Nov 2017 23:55:15 +0100
> After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from
> sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow
> some simplification" all relevant code pieces run in process context
> anyway and I don't think we need the disabling of interrupts any longer.
>
> Interestingly enough, latter commit already removed the comment
> explaining why interrupts need to be temporarily disabled.
>
> On my system phy interrupt mode works fine with this patch.
> However I may miss something, especially in the context of shared phy
> interrupts, therefore I'd appreciate if more people could test this.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Ok, applied.
But if this causes regressions I'm reverting.
next prev parent reply other threads:[~2017-12-04 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 22:55 [PATCH net-next resubmit 1/2] net: phy: core: remove now uneeded disabling of interrupts Heiner Kallweit
2017-11-30 22:57 ` [PATCH net-next resubmit 2/2] net: phy: core: don't disable device interrupts in phy_change Heiner Kallweit
2017-12-04 15:24 ` David Miller
2017-12-04 15:24 ` David Miller [this message]
2017-12-04 15:46 ` [PATCH net-next resubmit 1/2] net: phy: core: remove now uneeded disabling of interrupts Ard Biesheuvel
2017-12-04 15:50 ` David Miller
2017-12-04 15:51 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204.102417.1919875184945871383.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=ard.biesheuvel@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox