From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Edward Cree <ecree@solarflare.com>
Cc: davem <davem@davemloft.net>,
netdev@vger.kernel.org, Jann Horn <jannh@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH net 1/2] bpf/verifier: fix bounds calculation on BPF_RSH
Date: Wed, 6 Dec 2017 17:47:45 -0800 [thread overview]
Message-ID: <20171207014743.tzgdme4j2wv5rysg@ast-mbp> (raw)
In-Reply-To: <20171205194413.opdsw3muh2b7ujw5@ast-mbp.dhcp.thefacebook.com>
On Tue, Dec 05, 2017 at 11:44:14AM -0800, Alexei Starovoitov wrote:
> On Tue, Dec 05, 2017 at 07:15:18PM +0000, Edward Cree wrote:
> > Incorrect signed bounds were being computed, although this had no effect
> > since the propagation in __reg_deduce_bounds() happened to overwrite them.
> >
> > Fixes: b03c9f9fdc37 ("bpf/verifier: track signed and unsigned min/max values")
> > Reported-by: Jann Horn <jannh@google.com>
> > Signed-off-by: Edward Cree <ecree@solarflare.com>
>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
turned out this one is incomplete fix. The more complete set
from Jann and Ed will be coming.
next prev parent reply other threads:[~2017-12-07 1:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 19:13 [PATCH net 0/2] bpf/verifier: fix bounds calculation on BPF_RSH Edward Cree
2017-12-05 19:15 ` [PATCH net 1/2] " Edward Cree
2017-12-05 19:35 ` Jann Horn
2017-12-05 19:44 ` Alexei Starovoitov
2017-12-07 1:47 ` Alexei Starovoitov [this message]
2017-12-05 19:15 ` [PATCH net 2/2] selftests/bpf: Add a test for shifts of values that might be negative Edward Cree
2017-12-05 19:40 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207014743.tzgdme4j2wv5rysg@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jannh@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox