From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: "Nikita V. Shirokov" <tehnerd@fb.com>
Cc: netdev <netdev@vger.kernel.org>,
ast@kernel.org, vnuorval@tcs.hut.fi,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v2] adding missing rcu_read_unlock in ipxip6_rcv
Date: Wed, 6 Dec 2017 17:54:24 -0800 [thread overview]
Message-ID: <20171207015422.xuskvzk7mczzjg3d@ast-mbp> (raw)
In-Reply-To: <20171207011543.2877447-1-tehnerd@fb.com>
On Wed, Dec 06, 2017 at 05:15:43PM -0800, Nikita V. Shirokov wrote:
> commit 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels")
> introduced new exit point in ipxip6_rcv. however rcu_read_unlock is
> missing there. this diff is fixing this
>
> v1->v2:
> instead of doing rcu_read_unlock in place, we are going to "drop"
> section (to prevent skb leakage)
>
> Signed-off-by: Nikita V. Shirokov <tehnerd@fb.com>
thanks for fixing my mess.
Fixes: 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels")
Acked-by: Alexei Starovoitov <ast@kernel.org>
next prev parent reply other threads:[~2017-12-07 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 1:15 [PATCH net v2] adding missing rcu_read_unlock in ipxip6_rcv Nikita V. Shirokov
2017-12-07 1:54 ` Alexei Starovoitov [this message]
2017-12-07 19:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207015422.xuskvzk7mczzjg3d@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tehnerd@fb.com \
--cc=vnuorval@tcs.hut.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox