From: David Miller <davem@davemloft.net>
To: qiang.zhao@nxp.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: marvell: enable a errata for 88E1145
Date: Fri, 15 Dec 2017 10:47:04 -0500 (EST) [thread overview]
Message-ID: <20171215.104704.651511100967508376.davem@davemloft.net> (raw)
In-Reply-To: <20171215061332.42133-1-qiang.zhao@nxp.com>
From: Zhao Qiang <qiang.zhao@nxp.com>
Date: Fri, 15 Dec 2017 14:13:32 +0800
> The patch below
> commit f2899788353c ("net: phy: marvell: Limit errata to 88m1101")
> limit a errata's scope to 88E1101.
> However, 88E1145 also need this errata, set config_aneg to
> m88e1101_config_aneg for 88E1145
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
The proper way to say that a patch fixes a particular commit it to
reference it in a "Fixes: " tag, like this:
====================
Fixes: f2899788353c ("net: phy: marvell: Limit errata to 88m1101")
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
====================
And then you don't need to reference it explicitly in your commit
message, you can just instead say:
Limit 88m1101 autoneg errata to 88E1145 as well.
Please fix up your submission like this and resubmit.
Thank you.
prev parent reply other threads:[~2017-12-15 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 6:13 [PATCH] net: phy: marvell: enable a errata for 88E1145 Zhao Qiang
2017-12-15 15:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215.104704.651511100967508376.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=qiang.zhao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox