From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, mlxsw@mellanox.com,
daniel@iogearbox.net
Subject: Re: [patch net 1/2] net: sched: fix clsact init error path
Date: Fri, 15 Dec 2017 15:44:49 -0500 (EST) [thread overview]
Message-ID: <20171215.154449.1971297738166148632.davem@davemloft.net> (raw)
In-Reply-To: <20171215114013.6425-2-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 15 Dec 2017 12:40:12 +0100
> From: Jiri Pirko <jiri@mellanox.com>
>
> Since in qdisc_create, the destroy op is called when init fails, we
> don't do cleanup in init and leave it up to destroy.
> This fixes use-after-free when trying to put already freed block.
>
> Fixes: 6e40cf2d4dee ("net: sched: use extended variants of block_get/put in ingress and clsact qdiscs")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied.
next prev parent reply other threads:[~2017-12-15 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 11:40 [patch net 0/2] net: sched: couple of fixes on ingress/clsact init error path Jiri Pirko
2017-12-15 11:40 ` [patch net 1/2] net: sched: fix clsact " Jiri Pirko
2017-12-15 19:17 ` Cong Wang
2017-12-15 20:44 ` David Miller [this message]
2017-12-15 11:40 ` [patch net 2/2] net: sched: fix static key imbalance in case of ingress/clsact_init error Jiri Pirko
2017-12-15 19:18 ` Cong Wang
2017-12-15 20:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215.154449.1971297738166148632.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox