From: Jiri Pirko <jiri@resnulli.us>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, netdev@vger.kernel.org, arkadis@mellanox.com,
idosch@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch net-next] mlxsw: spectrum: Add "spectrum" prefix macro
Date: Tue, 19 Dec 2017 17:17:36 +0100 [thread overview]
Message-ID: <20171219161736.GH1928@nanopsycho> (raw)
In-Reply-To: <20171219.110906.560509930655165996.davem@davemloft.net>
Tue, Dec 19, 2017 at 05:09:06PM CET, davem@davemloft.net wrote:
>From: Joe Perches <joe@perches.com>
>Date: Sun, 17 Dec 2017 08:25:00 -0800
>
>> On Sun, 2017-12-17 at 17:15 +0100, Jiri Pirko wrote:
>>> From: Arkadi Sharshevsky <arkadis@mellanox.com>
>>>
>>> Add "spectrum" string prefix macro for error strings.
>> []
>>> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
>> []
>>> @@ -4168,13 +4168,11 @@ mlxsw_sp_master_lag_check(struct mlxsw_sp *mlxsw_sp,
>>> u16 lag_id;
>>>
>>> if (mlxsw_sp_lag_index_get(mlxsw_sp, lag_dev, &lag_id) != 0) {
>>> - NL_SET_ERR_MSG(extack,
>>> - "spectrum: Exceeded number of supported LAG devices");
>>> + NL_SET_ERR_MSG(extack, MLXSW_SP_PREFIX "Exceeded number of supported LAG devices");
>>
>> Perhaps use NL_SET_ERR_MSG_MOD instead.
>
>Yeah that probably makes sense.
Yes. Thanks
prev parent reply other threads:[~2017-12-19 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 16:15 [patch net-next] mlxsw: spectrum: Add "spectrum" prefix macro Jiri Pirko
2017-12-17 16:25 ` Joe Perches
2017-12-19 16:09 ` David Miller
2017-12-19 16:17 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219161736.GH1928@nanopsycho \
--to=jiri@resnulli.us \
--cc=arkadis@mellanox.com \
--cc=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=joe@perches.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox