From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: Tomer.Tayar@cavium.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
Ariel.Elior@cavium.com, Michal.Kalderon@cavium.com,
Yuval.Bason@cavium.com, Ram.Amrani@cavium.com,
Manish.Chopra@cavium.com, Chad.Dupuis@cavium.com,
Manish.Rangankar@cavium.com
Subject: Re: [PATCH net-next] qed*: Utilize FW 8.33.1.0
Date: Wed, 20 Dec 2017 11:54:03 -0500 (EST) [thread overview]
Message-ID: <20171220.115403.2203972051867900874.davem@davemloft.net> (raw)
In-Reply-To: <20171219154651.30930d2a@cakuba.netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 19 Dec 2017 15:46:51 -0800
> On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote:
>> Sorry for the very long patch.
>> The firmware changes are spread all over w/o a good modularity.
>
> Rings false. Significant portion of this patch is just whitespace
> and comment changes.
Totally agreed.
This thing is beyond huge already, adding unrelated whitespace and
comment changes make reviewing it even more impossible.
next prev parent reply other threads:[~2017-12-20 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 14:05 [PATCH net-next] qed*: Utilize FW 8.33.1.0 Tomer Tayar
2017-12-19 23:46 ` Jakub Kicinski
2017-12-20 16:54 ` David Miller [this message]
2017-12-21 10:43 ` kbuild test robot
2017-12-22 9:57 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220.115403.2203972051867900874.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@cavium.com \
--cc=Chad.Dupuis@cavium.com \
--cc=Manish.Chopra@cavium.com \
--cc=Manish.Rangankar@cavium.com \
--cc=Michal.Kalderon@cavium.com \
--cc=Ram.Amrani@cavium.com \
--cc=Tomer.Tayar@cavium.com \
--cc=Yuval.Bason@cavium.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox