From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, daniel@iogearbox.net, oss-drivers@netronome.com
Subject: Re: [PATCH net 1/2] cls_bpf: fix offload assumptions after callback conversion
Date: Wed, 20 Dec 2017 07:05:39 +0100 [thread overview]
Message-ID: <20171220060539.GA1916@nanopsycho> (raw)
In-Reply-To: <20171219213214.1084-2-jakub.kicinski@netronome.com>
Tue, Dec 19, 2017 at 10:32:13PM CET, jakub.kicinski@netronome.com wrote:
>cls_bpf used to take care of tracking what offload state a filter
>is in, i.e. it would track if offload request succeeded or not.
>This information would then be used to issue correct requests to
>the driver, e.g. requests for statistics only on offloaded filters,
>removing only filters which were offloaded, using add instead of
>replace if previous filter was not added etc.
>
>This tracking of offload state no longer functions with the new
>callback infrastructure. There could be multiple entities trying
>to offload the same filter.
>
>Throw out all the tracking and corresponding commands and simply
>pass to the drivers both old and new bpf program. Drivers will
>have to deal with offload state tracking by themselves.
>
>Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload")
>Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks Jakub!
next prev parent reply other threads:[~2017-12-20 6:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 21:32 [PATCH net 0/2] cls_bpf: fix offload state tracking with block callbacks Jakub Kicinski
2017-12-19 21:32 ` [PATCH net 1/2] cls_bpf: fix offload assumptions after callback conversion Jakub Kicinski
2017-12-20 6:05 ` Jiri Pirko [this message]
2017-12-19 21:32 ` [PATCH net 2/2] nfp: bpf: keep track of the offloaded program Jakub Kicinski
2017-12-20 11:33 ` [oss-drivers] [PATCH net 0/2] cls_bpf: fix offload state tracking with block callbacks Quentin Monnet
2017-12-20 18:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220060539.GA1916@nanopsycho \
--to=jiri@resnulli.us \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox