From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ip6_tunnel: allow ip6gre dev mtu to be set below 1280
Date: Tue, 02 Jan 2018 12:36:40 -0500 (EST) [thread overview]
Message-ID: <20180102.123640.1005693862725388582.davem@davemloft.net> (raw)
In-Reply-To: <2593c4a11b5ea0cf4efbec5517b7adec72ab4c17.1514184312.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 25 Dec 2017 14:45:12 +0800
> Commit 582442d6d5bc ("ipv6: Allow the MTU of ipip6 tunnel to be set
> below 1280") fixed a mtu setting issue. It works for ipip6 tunnel.
>
> But ip6gre dev updates the mtu also with ip6_tnl_change_mtu. Since
> the inner packet over ip6gre can be ipv4 and it's mtu should also
> be allowed to set below 1280, the same issue also exists on ip6gre.
>
> This patch is to fix it by simply changing to check if parms.proto
> is IPPROTO_IPV6 in ip6_tnl_change_mtu instead, to make ip6gre to
> go to 'else' branch.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
prev parent reply other threads:[~2018-01-02 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 6:45 [PATCH net] ip6_tunnel: allow ip6gre dev mtu to be set below 1280 Xin Long
2018-01-02 17:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102.123640.1005693862725388582.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox