From: Andy Gospodarek <andy@greyhouse.net>
To: Tal Gilboa <talgi@mellanox.com>
Cc: netdev@vger.kernel.org, mchan@broadcom.com,
ogerlitz@mellanox.com, Andy Gospodarek <gospo@broadcom.com>
Subject: Re: [PATCH net-next v2 06/10] net/mlx5e: Change Mellanox references in DIM code
Date: Mon, 8 Jan 2018 09:18:13 -0500 [thread overview]
Message-ID: <20180108141813.GB87664@C02RW35GFVH8.dhcp.broadcom.net> (raw)
In-Reply-To: <4de12484-6718-0926-e134-e9266dbcbe26@mellanox.com>
On Sun, Jan 07, 2018 at 11:44:48AM +0200, Tal Gilboa wrote:
>
>
> On 1/6/2018 12:58 AM, Andy Gospodarek wrote:
> > From: Andy Gospodarek <gospo@broadcom.com>
> >
> > Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and
> > NET_DIM, respectively, in code that handles dynamic interrupt
> > moderation. Also change all references from 'am' to 'dim' when used as
> > local variables.
> >
> > Signed-off-by: Andy Gospodarek <gospo@broadcom.com>
> > Acked-by: Tal Gilboa <talgi@mellanox.com>
> > Acked-by: Saeed Mahameed <saeedm@mellanox.com>
> >
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/en.h | 12 +-
> > drivers/net/ethernet/mellanox/mlx5/core/en_dim.c | 14 +-
> > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 12 +-
> > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 52 ++--
> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 4 +-
> > drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c | 2 +-
> > drivers/net/ethernet/mellanox/mlx5/core/net_dim.c | 284 ++++++++++-----------
> > drivers/net/ethernet/mellanox/mlx5/core/net_dim.h | 63 +++--
> > 8 files changed, 232 insertions(+), 211 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> > index 121f280..732f275 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en.h
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h
> > @@ -115,6 +115,9 @@
> > #define MLX5E_PARAMS_DEFAULT_MIN_RX_WQES 0x80
> > #define MLX5E_PARAMS_DEFAULT_MIN_RX_WQES_MPW 0x2
> > +#define MLX5E_CQ_PERIOD_MODE_START_FROM_EQE 0x0
> > +#define MLX5E_CQ_PERIOD_MODE_START_FROM_CQE 0x1
> > +
>
> This enum should be defined under include/linux/mlx5/mlx5_ifc.h:
> enum {
> MLX5_CQ_PERIOD_MODE_START_FROM_EQE = 0x0,
> MLX5_CQ_PERIOD_MODE_START_FROM_CQE = 0x1,
> MLX5_CQ_PERIOD_NUM_MODES
> };
>
> We already include this in the relevant files. This was changed in patch
> 01/10, please revert.
>
Ah yes. I'd forgotten I moved that out of there to start and I'll move it
back. Thanks!
next prev parent reply other threads:[~2018-01-08 14:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 22:58 [PATCH net-next v2 00/10] net: create dynamic software irq moderation library Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 01/10] net/mlx5e: Move interrupt moderation structs to new file Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 02/10] net/mlx5e: Move interrupt moderation forward declarations Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 03/10] net/mlx5e: Remove rq references in mlx5e_rx_am Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 04/10] net/mlx5e: Move AM logic enums Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 05/10] net/mlx5e: Move generic functions to new file Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 06/10] net/mlx5e: Change Mellanox references in DIM code Andy Gospodarek
2018-01-07 9:44 ` Tal Gilboa
2018-01-08 14:18 ` Andy Gospodarek [this message]
2018-01-05 22:58 ` [PATCH net-next v2 07/10] net/mlx5e: Move dynamic interrupt coalescing code to include/linux Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 08/10] net/dim: use struct net_dim_sample as arg to net_dim Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation Andy Gospodarek
2018-01-05 23:17 ` Michael Chan
2018-01-08 10:50 ` Vasundhara Volam
2018-01-08 14:04 ` Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108141813.GB87664@C02RW35GFVH8.dhcp.broadcom.net \
--to=andy@greyhouse.net \
--cc=gospo@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=talgi@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox