From: Andy Gospodarek <andy@greyhouse.net>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: netdev@vger.kernel.org, mchan@broadcom.com, talgi@mellanox.com,
ogerlitz@mellanox.com, Andy Gospodarek <gospo@broadcom.com>
Subject: Re: [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation
Date: Mon, 8 Jan 2018 09:04:58 -0500 [thread overview]
Message-ID: <20180108140458.GA87664@C02RW35GFVH8.dhcp.broadcom.net> (raw)
In-Reply-To: <CAACQVJp7xroGF=uFNHoQ_vBhTX0fvAnG7p2RmJ-4p+Utu_9pEw@mail.gmail.com>
On Mon, Jan 08, 2018 at 04:20:04PM +0530, Vasundhara Volam wrote:
> Hi Andy,
>
> If you are re-doing the patch, could you modify a minor comment below?
>
> On Sat, Jan 6, 2018 at 4:28 AM, Andy Gospodarek <andy@greyhouse.net> wrote:
>
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c
> > new file mode 100644
> > index 0000000..156e025
> > --- /dev/null
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c
> > @@ -0,0 +1,32 @@
> > +/*
> > + * Copyright (c) 2017 Broadcom Limited
> You have to modify year here.
> Also, First line driver description is missing "Broadcom NetXtreme-C/E
> network driver."
> Could you modify it?
Sure I could make those changes since it looks like I need a v3 anyway.
Thanks for the review.
next prev parent reply other threads:[~2018-01-08 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 22:58 [PATCH net-next v2 00/10] net: create dynamic software irq moderation library Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 01/10] net/mlx5e: Move interrupt moderation structs to new file Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 02/10] net/mlx5e: Move interrupt moderation forward declarations Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 03/10] net/mlx5e: Remove rq references in mlx5e_rx_am Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 04/10] net/mlx5e: Move AM logic enums Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 05/10] net/mlx5e: Move generic functions to new file Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 06/10] net/mlx5e: Change Mellanox references in DIM code Andy Gospodarek
2018-01-07 9:44 ` Tal Gilboa
2018-01-08 14:18 ` Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 07/10] net/mlx5e: Move dynamic interrupt coalescing code to include/linux Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 08/10] net/dim: use struct net_dim_sample as arg to net_dim Andy Gospodarek
2018-01-05 22:58 ` [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation Andy Gospodarek
2018-01-05 23:17 ` Michael Chan
2018-01-08 10:50 ` Vasundhara Volam
2018-01-08 14:04 ` Andy Gospodarek [this message]
2018-01-05 22:58 ` [PATCH net-next v2 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108140458.GA87664@C02RW35GFVH8.dhcp.broadcom.net \
--to=andy@greyhouse.net \
--cc=gospo@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=talgi@mellanox.com \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox