From: David Miller <davem@davemloft.net>
To: tariqt@mellanox.com
Cc: netdev@vger.kernel.org, eranbe@mellanox.com, eugenia@mellanox.com
Subject: Re: [PATCH net-next 0/3] ethtool ringparam upper bound
Date: Tue, 09 Jan 2018 11:55:08 -0500 (EST) [thread overview]
Message-ID: <20180109.115508.2272049544268725175.davem@davemloft.net> (raw)
In-Reply-To: <1515420026-11970-1-git-send-email-tariqt@mellanox.com>
From: Tariq Toukan <tariqt@mellanox.com>
Date: Mon, 8 Jan 2018 16:00:23 +0200
> This patchset by Jenny adds sanity checks in ethtool ringparam
> operation for input upper bounds, similarly to what's done in
> ethtool_set_channels.
>
> The checks are added in patch 1, using a call to get_ringparam
> prior to calling set_ringparam NDO.
>
> Patch 2 changes the function's behavior in mlx4_en, so that
> it returns an error for out-of-range input, instead of rounding
> it to closest valid, similar to mlx5e.
>
> Patch 3 removes the upper bound checks in mlx5e_ethtool_set_ringparam
> as it becomes redundant.
>
> Series generated against net-next commit:
> f66faae2f80a Merge branch 'ipv6-ipv4-nexthop-align'
Series applied, thank you.
prev parent reply other threads:[~2018-01-09 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 14:00 [PATCH net-next 0/3] ethtool ringparam upper bound Tariq Toukan
2018-01-08 14:00 ` [PATCH net-next 1/3] ethtool: Ensure new ring parameters are within bounds during SRINGPARAM Tariq Toukan
2018-01-09 2:23 ` Jakub Kicinski
2018-01-09 7:30 ` Tariq Toukan
2018-01-09 7:35 ` Jakub Kicinski
2018-01-08 14:00 ` [PATCH net-next 2/3] net/mlx4_en: Align behavior of set ring size flow via ethtool Tariq Toukan
2018-01-08 14:00 ` [PATCH net-next 3/3] net/mlx5e: Remove redundant checks in set_ringparam Tariq Toukan
2018-01-09 16:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109.115508.2272049544268725175.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=eugenia@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox