* [PATCH] netfilter: nf_tables: flow_offload depends on flow_table
@ 2018-01-12 15:50 Arnd Bergmann
2018-01-16 0:48 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-01-12 15:50 UTC (permalink / raw)
To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
David S. Miller
Cc: Arnd Bergmann, William Breathitt Gray, Pablo M. Bermudo Garay,
Manuel Messner, netfilter-devel, coreteam, netdev, linux-kernel
Without CONFIG_NF_FLOW_TABLE, the new nft_flow_offload module produces
a link error:
net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_iterate_cleanup':
nft_flow_offload.c:(.text+0xb0): undefined reference to `nf_flow_table_iterate'
net/netfilter/nft_flow_offload.o: In function `flow_offload_iterate_cleanup':
nft_flow_offload.c:(.text+0x160): undefined reference to `flow_offload_dead'
net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_eval':
nft_flow_offload.c:(.text+0xc4c): undefined reference to `flow_offload_alloc'
nft_flow_offload.c:(.text+0xc64): undefined reference to `flow_offload_add'
nft_flow_offload.c:(.text+0xc94): undefined reference to `flow_offload_free'
This adds a Kconfig dependency for it.
Fixes: a3c90f7a2323 ("netfilter: nf_tables: flow offload expression")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
net/netfilter/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index ea447826e127..9019fa98003d 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -506,7 +506,7 @@ config NFT_CT
connection tracking information such as the flow state.
config NFT_FLOW_OFFLOAD
- depends on NF_CONNTRACK
+ depends on NF_CONNTRACK && NF_FLOW_TABLE
tristate "Netfilter nf_tables hardware flow offload module"
help
This option adds the "flow_offload" expression that you can use to
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] netfilter: nf_tables: flow_offload depends on flow_table
2018-01-12 15:50 [PATCH] netfilter: nf_tables: flow_offload depends on flow_table Arnd Bergmann
@ 2018-01-16 0:48 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2018-01-16 0:48 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jozsef Kadlecsik, Florian Westphal, David S. Miller,
William Breathitt Gray, Pablo M. Bermudo Garay, Manuel Messner,
netfilter-devel, coreteam, netdev, linux-kernel
On Fri, Jan 12, 2018 at 04:50:26PM +0100, Arnd Bergmann wrote:
> Without CONFIG_NF_FLOW_TABLE, the new nft_flow_offload module produces
> a link error:
>
> net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_iterate_cleanup':
> nft_flow_offload.c:(.text+0xb0): undefined reference to `nf_flow_table_iterate'
> net/netfilter/nft_flow_offload.o: In function `flow_offload_iterate_cleanup':
> nft_flow_offload.c:(.text+0x160): undefined reference to `flow_offload_dead'
> net/netfilter/nft_flow_offload.o: In function `nft_flow_offload_eval':
> nft_flow_offload.c:(.text+0xc4c): undefined reference to `flow_offload_alloc'
> nft_flow_offload.c:(.text+0xc64): undefined reference to `flow_offload_add'
> nft_flow_offload.c:(.text+0xc94): undefined reference to `flow_offload_free'
>
> This adds a Kconfig dependency for it.
Applied, thanks Arnd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-16 0:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-12 15:50 [PATCH] netfilter: nf_tables: flow_offload depends on flow_table Arnd Bergmann
2018-01-16 0:48 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox