public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: borkmann@iogearbox.net, kafai@fb.com, ast@kernel.org
Cc: netdev@vger.kernel.org, brouer@redhat.com
Subject: [bpf-next PATCH v4 6/7] bpf: sockmap put client sockets in blocking mode
Date: Mon, 22 Jan 2018 10:36:53 -0800	[thread overview]
Message-ID: <20180122183653.11150.8018.stgit@john-Precision-Tower-5810> (raw)
In-Reply-To: <20180122183256.11150.69794.stgit@john-Precision-Tower-5810>

Put client sockets in blocking mode otherwise with sendmsg tests
its easy to overrun the socket buffers which results in the test
being aborted.

The original non-blocking was added to handle listen/accept with
a single thread the client/accepted sockets do not need to be
non-blocking.

Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
---
 samples/sockmap/sockmap_user.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/sockmap/sockmap_user.c b/samples/sockmap/sockmap_user.c
index f9d3785..fe943c9 100644
--- a/samples/sockmap/sockmap_user.c
+++ b/samples/sockmap/sockmap_user.c
@@ -109,7 +109,7 @@ static int sockmap_init_sockets(void)
 	}
 
 	/* Non-blocking sockets */
-	for (i = 0; i < 4; i++) {
+	for (i = 0; i < 2; i++) {
 		err = ioctl(*fds[i], FIONBIO, (char *)&one);
 		if (err < 0) {
 			perror("ioctl s1 failed()");

  parent reply	other threads:[~2018-01-22 18:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 18:35 [bpf-next PATCH v4 0/7] Series short description John Fastabend
2018-01-22 18:35 ` [bpf-next PATCH v4 1/7] bpf: refactor sockmap sample program update for arg parsing John Fastabend
2018-01-22 18:35 ` [bpf-next PATCH v4 2/7] bpf: add sendmsg option for testing BPF programs John Fastabend
2018-01-24 10:04   ` Daniel Borkmann
2018-01-22 18:36 ` [bpf-next PATCH v4 3/7] bpf: sockmap sample, use fork() for send and recv John Fastabend
2018-01-22 18:36 ` [bpf-next PATCH v4 4/7] bpf: sockmap sample, report bytes/sec John Fastabend
2018-01-22 18:36 ` [bpf-next PATCH v4 5/7] bpf: sockmap sample add base test without any BPF for comparison John Fastabend
2018-01-22 18:36 ` John Fastabend [this message]
2018-01-22 18:37 ` [bpf-next PATCH v4 7/7] bpf: sockmap set rlimit John Fastabend
2018-01-24 10:00 ` [bpf-next PATCH v4 0/7] Series short description Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180122183653.11150.8018.stgit@john-Precision-Tower-5810 \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=borkmann@iogearbox.net \
    --cc=brouer@redhat.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox