Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kubakici@wp.pl>
To: Sathya Perla <sathya.perla@broadcom.com>
Cc: netdev@vger.kernel.org, jiri@resnulli.us
Subject: Re: [PATCH] cls_flower: check if filter is in HW before calling fl_hw_destroy_filter()
Date: Wed, 24 Jan 2018 14:23:17 -0800	[thread overview]
Message-ID: <20180124142317.772643c7@cakuba.netronome.com> (raw)
In-Reply-To: <1516794175-5679-1-git-send-email-sathya.perla@broadcom.com>

On Wed, 24 Jan 2018 17:12:55 +0530, Sathya Perla wrote:
> When a filter cannot be added in HW (i.e, fl_hw_replace_filter() returns
> error), the TCA_CLS_FLAGS_IN_HW flag is not set in the filter flags.
> 
> This flag (via tc_in_hw()) must be checked before issuing the call
> to delete a filter in HW (fl_hw_destroy_filter()) and before issuing the
> call to query stats (fl_hw_update_stats()).
> 
> Signed-off-by: Sathya Perla <sathya.perla@broadcom.com>

Could you explain why you want to make that change?  Saying "tc_in_hw()
must be checked" is a bit strong, tc_in_hw() is useless from correctness 
POV.  Your patch may be a good optimization, but with shared blocks in
the picture now tc_in_hw() == true doesn't mean it's in *your* HW.

  parent reply	other threads:[~2018-01-24 22:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 11:42 [PATCH] cls_flower: check if filter is in HW before calling fl_hw_destroy_filter() Sathya Perla
2018-01-24 16:07 ` Jiri Pirko
2018-01-25  5:52   ` Sathya Perla
2018-01-24 22:23 ` Jakub Kicinski [this message]
2018-01-25  5:51   ` Sathya Perla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124142317.772643c7@cakuba.netronome.com \
    --to=kubakici@wp.pl \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=sathya.perla@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox