From: Jiri Pirko <jiri@resnulli.us>
To: Sathya Perla <sathya.perla@broadcom.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] cls_flower: check if filter is in HW before calling fl_hw_destroy_filter()
Date: Wed, 24 Jan 2018 17:07:07 +0100 [thread overview]
Message-ID: <20180124160707.GH2234@nanopsycho> (raw)
In-Reply-To: <1516794175-5679-1-git-send-email-sathya.perla@broadcom.com>
Wed, Jan 24, 2018 at 12:42:55PM CET, sathya.perla@broadcom.com wrote:
>When a filter cannot be added in HW (i.e, fl_hw_replace_filter() returns
>error), the TCA_CLS_FLAGS_IN_HW flag is not set in the filter flags.
>
>This flag (via tc_in_hw()) must be checked before issuing the call
>to delete a filter in HW (fl_hw_destroy_filter()) and before issuing the
>call to query stats (fl_hw_update_stats()).
>
>Signed-off-by: Sathya Perla <sathya.perla@broadcom.com>
1) You have to indicate what tree you aim this to be applied on:
[patch net] or [patch net-next]
2) Please provided a "Fixes" line
3) Please use scripts/get_maintainer.pl to get the people to cc
4) Please aim the fix not only to cls_flower, but to other cls as well.
otherwise the patch looks ok.
next prev parent reply other threads:[~2018-01-24 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 11:42 [PATCH] cls_flower: check if filter is in HW before calling fl_hw_destroy_filter() Sathya Perla
2018-01-24 16:07 ` Jiri Pirko [this message]
2018-01-25 5:52 ` Sathya Perla
2018-01-24 22:23 ` Jakub Kicinski
2018-01-25 5:51 ` Sathya Perla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124160707.GH2234@nanopsycho \
--to=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox