From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] netfilter: xt_hashlimit: do not allow empty names
Date: Fri, 2 Feb 2018 13:17:23 +0100 [thread overview]
Message-ID: <20180202121723.47wr5qosugbdse76@salvia> (raw)
In-Reply-To: <alpine.LSU.2.20.1802021306530.14157@n3.vanv.qr>
On Fri, Feb 02, 2018 at 01:12:08PM +0100, Jan Engelhardt wrote:
> On Friday 2018-02-02 12:55, Pablo Neira Ayuso wrote:
>
> >On Fri, Feb 02, 2018 at 12:49:38PM +0100, Pablo Neira Ayuso wrote:
> >[...]
> >> bool net_valid_name(const char *name, size_t len)
> >> {
> >> ...
> >> }
> >
> >Am I missing anything in all these tricky string handling? Thanks!
>
> One will have to watch out for calls like
>
> net_valid_name(NLA_DATA(some_ifla_name), IFNAMSIZ)
>
> because quite some nlattrs (IFLA_NAME, IFLA_IFNAME to boot) are NLA_STRINGs
> (rather than NLA_NUL_STRINGs) and they are not \0-terminated.
As long as we use nla_str*() helpers, we're all good.
next prev parent reply other threads:[~2018-02-02 12:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 15:41 [PATCH net] netfilter: xt_hashlimit: do not allow empty names Eric Dumazet
2018-01-28 17:54 ` Eric Dumazet
2018-01-28 21:54 ` Florian Westphal
2018-02-02 11:49 ` Pablo Neira Ayuso
2018-02-02 11:55 ` Pablo Neira Ayuso
2018-02-02 11:56 ` Pablo Neira Ayuso
2018-02-02 12:12 ` Jan Engelhardt
2018-02-02 12:17 ` Pablo Neira Ayuso [this message]
2018-02-02 16:27 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202121723.47wr5qosugbdse76@salvia \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox