From: Tycho Andersen <tycho-E0fblnxP3wo@public.gmane.org>
To: Sargun Dhillon <sargun-GaZTRHToo+CzQB+pC5nmwQ@public.gmane.org>
Cc: Will Drewry <wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Alexei Starovoitov <ast-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
Subject: Re: [net-next v3 1/2] bpf, seccomp: Add eBPF filter capabilities
Date: Mon, 26 Feb 2018 20:57:46 -0700 [thread overview]
Message-ID: <20180227035746.vh5mw7ijbyg3mbq3@cisco> (raw)
In-Reply-To: <CAMp4zn9Gk62Wa6WYtmn9qj5zuFFR4MzS4TUGsG5Bx-JYZEc_4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, Feb 26, 2018 at 07:49:48PM -0800, Sargun Dhillon wrote:
> On Mon, Feb 26, 2018 at 4:54 PM, Tycho Andersen <tycho-E0fblnxP3wo@public.gmane.org> wrote:
> > On Mon, Feb 26, 2018 at 07:27:05AM +0000, Sargun Dhillon wrote:
> >> +config SECCOMP_FILTER_EXTENDED
> >> + bool "Extended BPF seccomp filters"
> >> + depends on SECCOMP_FILTER && BPF_SYSCALL
> >> + depends on !CHECKPOINT_RESTORE
> >
> > Why not just give -EINVAL or something in case one of these is
> > requested, instead of making them incompatible at compile time?
> >
> > Tycho
> There's already code to return -EMEDIUMTYPE if it's a non-classic, or
> non-saved filter. Under the normal case, with CHECKPOINT_RESTORE
> enabled, you should never be able to get that. I think it makes sense
> to preserve this behaviour.
Oh, right. So can't we just drop this, and the existing code will
DTRT, i.e. give you -EMEDIUMTYPE because the new filters aren't
supported, until they are?
Tycho
next prev parent reply other threads:[~2018-02-27 3:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 7:27 [net-next v3 1/2] bpf, seccomp: Add eBPF filter capabilities Sargun Dhillon
[not found] ` <20180226072702.GA27057-du9IEJ8oIxHXYT48pCVpJ3c7ZZ+wIVaZYkHkVr5ML8kVGlcevz2xqA@public.gmane.org>
2018-02-27 0:54 ` Tycho Andersen
2018-02-27 3:49 ` Sargun Dhillon
[not found] ` <CAMp4zn9Gk62Wa6WYtmn9qj5zuFFR4MzS4TUGsG5Bx-JYZEc_4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-27 3:57 ` Tycho Andersen [this message]
2018-02-27 4:08 ` Sargun Dhillon
[not found] ` <CAMp4zn-NNWT4mpmb_-5MV5urhj3KCzF=ZSoiHX54pLw3847Xrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-27 4:31 ` Kees Cook
2018-03-01 22:05 ` Andy Lutomirski
[not found] ` <CALCETrVwwTu0RTepfzq4jAW7d-7qKizKQdmAUhua+Md-Ljv1uQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-05 16:10 ` Tycho Andersen
2018-03-05 22:51 ` Sargun Dhillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227035746.vh5mw7ijbyg3mbq3@cisco \
--to=tycho-e0fblnxp3wo@public.gmane.org \
--cc=ast-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sargun-GaZTRHToo+CzQB+pC5nmwQ@public.gmane.org \
--cc=wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox