From: David Miller <davem@davemloft.net>
To: xiangxia.m.yue@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: Support tcp socket allocated counter in namespace.
Date: Wed, 28 Feb 2018 09:41:47 -0500 (EST) [thread overview]
Message-ID: <20180228.094147.1456557446129712432.davem@davemloft.net> (raw)
In-Reply-To: <CAMDZJNU9J2E=3nMuZPHhXh3Vh3xiyYEkzZVNNO2DdhR4Naywjw@mail.gmail.com>
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Date: Wed, 28 Feb 2018 21:01:52 +0800
>> The amount of new conditional tests in these fast paths are not
>> justified for this new counter which is of debatable usefullness.
> sorry, too late for reply. Did you mean this counter will affect performance ?
> I tested the patch witch netperf.
A single flow TCP session with no loss doesn't tell us much.
I just know from how these things go that under load, and with
all kinds of different flows with different characterstics,
every conditional test in the fast paths matter.
If you want to have a chance at your change getting accepted,
running all kinds of benchmarks won't do it.
Instead, please find a way to make your feature work without all of
the newly added tests (whilst not adding another cost at the same
time).
Thank you.
next prev parent reply other threads:[~2018-02-28 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 2:44 [PATCH] tcp: Support tcp socket allocated counter in namespace Tonghao Zhang
2018-02-13 17:19 ` David Miller
2018-02-28 13:01 ` Tonghao Zhang
2018-02-28 14:41 ` David Miller [this message]
2018-02-28 14:53 ` Tonghao Zhang
2018-02-28 19:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228.094147.1456557446129712432.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox