From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH] tcp: Support tcp socket allocated counter in namespace.
Date: Wed, 28 Feb 2018 22:53:10 +0800 [thread overview]
Message-ID: <CAMDZJNXM6fXqO_Q2a7WgGtS+0YR8LRUPiE5371cf2RWu7VJgHA@mail.gmail.com> (raw)
In-Reply-To: <20180228.094147.1456557446129712432.davem@davemloft.net>
On Wed, Feb 28, 2018 at 10:41 PM, David Miller <davem@davemloft.net> wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Date: Wed, 28 Feb 2018 21:01:52 +0800
>
>>> The amount of new conditional tests in these fast paths are not
>>> justified for this new counter which is of debatable usefullness.
>> sorry, too late for reply. Did you mean this counter will affect performance ?
>> I tested the patch witch netperf.
>
> A single flow TCP session with no loss doesn't tell us much.
>
> I just know from how these things go that under load, and with
> all kinds of different flows with different characterstics,
> every conditional test in the fast paths matter.
>
> If you want to have a chance at your change getting accepted,
> running all kinds of benchmarks won't do it.
>
> Instead, please find a way to make your feature work without all of
> the newly added tests (whilst not adding another cost at the same
> time).
Thanks for your explanation.
> Thank you.
next prev parent reply other threads:[~2018-02-28 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 2:44 [PATCH] tcp: Support tcp socket allocated counter in namespace Tonghao Zhang
2018-02-13 17:19 ` David Miller
2018-02-28 13:01 ` Tonghao Zhang
2018-02-28 14:41 ` David Miller
2018-02-28 14:53 ` Tonghao Zhang [this message]
2018-02-28 19:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMDZJNXM6fXqO_Q2a7WgGtS+0YR8LRUPiE5371cf2RWu7VJgHA@mail.gmail.com \
--to=xiangxia.m.yue@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox