From: Alexander Kurz <akurz@blala.de>
To: "David S . Miller" <davem@davemloft.net>
Cc: "Andrew F . Davis" <afd@ti.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
Freddy Xin <freddy@asix.com.tw>, Alexander Kurz <akurz@blala.de>
Subject: [PATCH v2 1/2] net: usb: asix88179_178a: set permanent address once only
Date: Thu, 8 Mar 2018 11:19:53 +0000 [thread overview]
Message-ID: <20180308111954.28885-1-akurz@blala.de> (raw)
The permanent address of asix88179_178a devices is read at probe time
and should not be overwritten later. Otherwise it may be overwritten
unintentionally with a configured address.
Signed-off-by: Alexander Kurz <akurz@blala.de>
---
drivers/net/usb/ax88179_178a.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index f32261ecd215..a6ef75907ae9 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1556,7 +1556,6 @@ static int ax88179_reset(struct usbnet *dev)
ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_NODE_ID, ETH_ALEN, ETH_ALEN,
dev->net->dev_addr);
- memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
/* RX bulk configuration */
memcpy(tmp, &AX88179_BULKIN_SIZE[0], 5);
--
2.11.0
next reply other threads:[~2018-03-08 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 11:19 Alexander Kurz [this message]
2018-03-08 11:19 ` [PATCH v2 2/2] net: usb: asix88179_178a: de-duplicate code Alexander Kurz
2018-03-31 12:16 ` Marc Zyngier
2018-04-01 18:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308111954.28885-1-akurz@blala.de \
--to=akurz@blala.de \
--cc=afd@ti.com \
--cc=davem@davemloft.net \
--cc=freddy@asix.com.tw \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox