From: John Fastabend <john.fastabend@gmail.com>
To: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net,
davejwatson@fb.com
Cc: netdev@vger.kernel.org
Subject: [bpf-next PATCH v2 10/18] bpf: add verifier tests for BPF_PROG_TYPE_SK_MSG
Date: Mon, 12 Mar 2018 12:23:55 -0700 [thread overview]
Message-ID: <20180312192355.8039.74913.stgit@john-Precision-Tower-5810> (raw)
In-Reply-To: <20180312192034.8039.70022.stgit@john-Precision-Tower-5810>
Test read and writes for BPF_PROG_TYPE_SK_MSG.
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
---
tools/testing/selftests/bpf/test_verifier.c | 54 +++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c
index 9eb05f3..db49528 100644
--- a/tools/testing/selftests/bpf/test_verifier.c
+++ b/tools/testing/selftests/bpf/test_verifier.c
@@ -1597,6 +1597,60 @@ struct test_val {
.prog_type = BPF_PROG_TYPE_SK_SKB,
},
{
+ "direct packet read for SK_MSG",
+ .insns = {
+ BPF_LDX_MEM(BPF_W, BPF_REG_2, BPF_REG_1,
+ offsetof(struct sk_msg_md, data)),
+ BPF_LDX_MEM(BPF_W, BPF_REG_3, BPF_REG_1,
+ offsetof(struct sk_msg_md, data_end)),
+ BPF_MOV64_REG(BPF_REG_0, BPF_REG_2),
+ BPF_ALU64_IMM(BPF_ADD, BPF_REG_0, 8),
+ BPF_JMP_REG(BPF_JGT, BPF_REG_0, BPF_REG_3, 1),
+ BPF_LDX_MEM(BPF_B, BPF_REG_0, BPF_REG_2, 0),
+ BPF_MOV64_IMM(BPF_REG_0, 0),
+ BPF_EXIT_INSN(),
+ },
+ .result = ACCEPT,
+ .prog_type = BPF_PROG_TYPE_SK_MSG,
+ },
+ {
+ "direct packet write for SK_MSG",
+ .insns = {
+ BPF_LDX_MEM(BPF_W, BPF_REG_2, BPF_REG_1,
+ offsetof(struct sk_msg_md, data)),
+ BPF_LDX_MEM(BPF_W, BPF_REG_3, BPF_REG_1,
+ offsetof(struct sk_msg_md, data_end)),
+ BPF_MOV64_REG(BPF_REG_0, BPF_REG_2),
+ BPF_ALU64_IMM(BPF_ADD, BPF_REG_0, 8),
+ BPF_JMP_REG(BPF_JGT, BPF_REG_0, BPF_REG_3, 1),
+ BPF_STX_MEM(BPF_B, BPF_REG_2, BPF_REG_2, 0),
+ BPF_MOV64_IMM(BPF_REG_0, 0),
+ BPF_EXIT_INSN(),
+ },
+ .result = ACCEPT,
+ .prog_type = BPF_PROG_TYPE_SK_MSG,
+ },
+ {
+ "overlapping checks for direct packet access SK_MSG",
+ .insns = {
+ BPF_LDX_MEM(BPF_W, BPF_REG_2, BPF_REG_1,
+ offsetof(struct sk_msg_md, data)),
+ BPF_LDX_MEM(BPF_W, BPF_REG_3, BPF_REG_1,
+ offsetof(struct sk_msg_md, data_end)),
+ BPF_MOV64_REG(BPF_REG_0, BPF_REG_2),
+ BPF_ALU64_IMM(BPF_ADD, BPF_REG_0, 8),
+ BPF_JMP_REG(BPF_JGT, BPF_REG_0, BPF_REG_3, 4),
+ BPF_MOV64_REG(BPF_REG_1, BPF_REG_2),
+ BPF_ALU64_IMM(BPF_ADD, BPF_REG_1, 6),
+ BPF_JMP_REG(BPF_JGT, BPF_REG_1, BPF_REG_3, 1),
+ BPF_LDX_MEM(BPF_H, BPF_REG_0, BPF_REG_2, 6),
+ BPF_MOV64_IMM(BPF_REG_0, 0),
+ BPF_EXIT_INSN(),
+ },
+ .result = ACCEPT,
+ .prog_type = BPF_PROG_TYPE_SK_MSG,
+ },
+ {
"check skb->mark is not writeable by sockets",
.insns = {
BPF_STX_MEM(BPF_W, BPF_REG_1, BPF_REG_1,
next prev parent reply other threads:[~2018-03-12 19:23 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 19:23 [bpf-next PATCH v2 00/18] bpf,sockmap: sendmsg/sendfile ULP John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 01/18] sock: make static tls function alloc_sg generic sock helper John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 02/18] sockmap: convert refcnt to an atomic refcnt John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 03/18] net: do_tcp_sendpages flag to avoid SKBTX_SHARED_FRAG John Fastabend
2018-03-15 18:40 ` David Miller
2018-03-12 19:23 ` [bpf-next PATCH v2 04/18] net: generalize sk_alloc_sg to work with scatterlist rings John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data John Fastabend
2018-03-15 18:41 ` David Miller
2018-03-15 21:59 ` Alexei Starovoitov
2018-03-15 22:08 ` John Fastabend
2018-03-15 22:17 ` Daniel Borkmann
2018-03-15 22:20 ` Alexei Starovoitov
2018-03-15 22:55 ` Daniel Borkmann
2018-03-15 23:06 ` Alexei Starovoitov
2018-03-16 0:37 ` Daniel Borkmann
2018-03-16 16:47 ` John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 06/18] bpf: sockmap, add bpf_msg_apply_bytes() helper John Fastabend
2018-03-15 18:41 ` David Miller
2018-03-15 20:32 ` Daniel Borkmann
2018-03-15 22:02 ` John Fastabend
2018-03-15 21:45 ` Alexei Starovoitov
2018-03-15 21:59 ` John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 07/18] bpf: sockmap, add msg_cork_bytes() helper John Fastabend
2018-03-15 18:41 ` David Miller
2018-03-12 19:23 ` [bpf-next PATCH v2 08/18] bpf: sk_msg program helper bpf_sk_msg_pull_data John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-15 20:25 ` Daniel Borkmann
2018-03-12 19:23 ` [bpf-next PATCH v2 09/18] bpf: add map tests for BPF_PROG_TYPE_SK_MSG John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:23 ` John Fastabend [this message]
2018-03-15 18:42 ` [bpf-next PATCH v2 10/18] bpf: add verifier " David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 11/18] bpf: sockmap sample, add option to attach SK_MSG program John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 12/18] bpf: sockmap sample, add sendfile test John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 13/18] bpf: sockmap sample, add data verification option John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 14/18] bpf: sockmap, add sample option to test apply_bytes helper John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 15/18] bpf: sockmap sample support for bpf_msg_cork_bytes() John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-15 20:15 ` Alexei Starovoitov
2018-03-15 22:04 ` John Fastabend
2018-03-12 19:24 ` [bpf-next PATCH v2 16/18] bpf: sockmap add SK_DROP tests John Fastabend
2018-03-15 18:43 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 17/18] bpf: sockmap sample test for bpf_msg_pull_data John Fastabend
2018-03-15 18:43 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 18/18] bpf: sockmap test script John Fastabend
2018-03-15 18:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312192355.8039.74913.stgit@john-Precision-Tower-5810 \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox