From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net,
davejwatson@fb.com, netdev@vger.kernel.org
Subject: Re: [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data
Date: Thu, 15 Mar 2018 14:59:55 -0700 [thread overview]
Message-ID: <20180315215954.wufvwdhcjpntdxbb@ast-mbp> (raw)
In-Reply-To: <20180312192329.8039.75277.stgit@john-Precision-Tower-5810>
On Mon, Mar 12, 2018 at 12:23:29PM -0700, John Fastabend wrote:
>
> +/* User return codes for SK_MSG prog type. */
> +enum sk_msg_action {
> + SK_MSG_DROP = 0,
> + SK_MSG_PASS,
> +};
do we really need new enum here?
It's the same as 'enum sk_action' and SK_DROP == SK_MSG_DROP
and there will be only drop/pass in both enums.
Also I don't see where these two new SK_MSG_* are used...
> +
> +/* user accessible metadata for SK_MSG packet hook, new fields must
> + * be added to the end of this structure
> + */
> +struct sk_msg_md {
> + __u32 data;
> + __u32 data_end;
> +};
I think it's time for me to ask for forgiveness :)
I used __u32 for data and data_end only because all other fields
in __sk_buff were __u32 at the time and I couldn't easily figure out
how to teach verifier to recognize 8-byte rewrites.
Unfortunately my mistake stuck and was copied over into xdp.
Since this is new struct let's do it right and add
'void *data, *data_end' here,
since bpf prog will use them as 'void *' pointers.
There are no compat issues here, since bpf is always 64-bit.
> +static int bpf_map_msg_verdict(int _rc, struct sk_msg_buff *md)
> +{
> + return ((_rc == SK_PASS) ?
> + (md->map ? __SK_REDIRECT : __SK_PASS) :
> + __SK_DROP);
you're using old SK_PASS here too ;)
that's to my point of not adding SK_MSG_PASS...
Overall the patch set looks absolutely great.
Thank you for working on it.
next prev parent reply other threads:[~2018-03-15 21:59 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 19:23 [bpf-next PATCH v2 00/18] bpf,sockmap: sendmsg/sendfile ULP John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 01/18] sock: make static tls function alloc_sg generic sock helper John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 02/18] sockmap: convert refcnt to an atomic refcnt John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 03/18] net: do_tcp_sendpages flag to avoid SKBTX_SHARED_FRAG John Fastabend
2018-03-15 18:40 ` David Miller
2018-03-12 19:23 ` [bpf-next PATCH v2 04/18] net: generalize sk_alloc_sg to work with scatterlist rings John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 05/18] bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data John Fastabend
2018-03-15 18:41 ` David Miller
2018-03-15 21:59 ` Alexei Starovoitov [this message]
2018-03-15 22:08 ` John Fastabend
2018-03-15 22:17 ` Daniel Borkmann
2018-03-15 22:20 ` Alexei Starovoitov
2018-03-15 22:55 ` Daniel Borkmann
2018-03-15 23:06 ` Alexei Starovoitov
2018-03-16 0:37 ` Daniel Borkmann
2018-03-16 16:47 ` John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 06/18] bpf: sockmap, add bpf_msg_apply_bytes() helper John Fastabend
2018-03-15 18:41 ` David Miller
2018-03-15 20:32 ` Daniel Borkmann
2018-03-15 22:02 ` John Fastabend
2018-03-15 21:45 ` Alexei Starovoitov
2018-03-15 21:59 ` John Fastabend
2018-03-12 19:23 ` [bpf-next PATCH v2 07/18] bpf: sockmap, add msg_cork_bytes() helper John Fastabend
2018-03-15 18:41 ` David Miller
2018-03-12 19:23 ` [bpf-next PATCH v2 08/18] bpf: sk_msg program helper bpf_sk_msg_pull_data John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-15 20:25 ` Daniel Borkmann
2018-03-12 19:23 ` [bpf-next PATCH v2 09/18] bpf: add map tests for BPF_PROG_TYPE_SK_MSG John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:23 ` [bpf-next PATCH v2 10/18] bpf: add verifier " John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 11/18] bpf: sockmap sample, add option to attach SK_MSG program John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 12/18] bpf: sockmap sample, add sendfile test John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 13/18] bpf: sockmap sample, add data verification option John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 14/18] bpf: sockmap, add sample option to test apply_bytes helper John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 15/18] bpf: sockmap sample support for bpf_msg_cork_bytes() John Fastabend
2018-03-15 18:42 ` David Miller
2018-03-15 20:15 ` Alexei Starovoitov
2018-03-15 22:04 ` John Fastabend
2018-03-12 19:24 ` [bpf-next PATCH v2 16/18] bpf: sockmap add SK_DROP tests John Fastabend
2018-03-15 18:43 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 17/18] bpf: sockmap sample test for bpf_msg_pull_data John Fastabend
2018-03-15 18:43 ` David Miller
2018-03-12 19:24 ` [bpf-next PATCH v2 18/18] bpf: sockmap test script John Fastabend
2018-03-15 18:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315215954.wufvwdhcjpntdxbb@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox