From: David Miller <davem@davemloft.net>
To: vinicius.gomes@intel.com
Cc: netdev@vger.kernel.org, randy.e.witt@intel.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net] skbuff: Fix not waking applications when errors are enqueued
Date: Fri, 16 Mar 2018 12:37:24 -0400 (EDT) [thread overview]
Message-ID: <20180316.123724.729271943170129684.davem@davemloft.net> (raw)
In-Reply-To: <20180314203209.26532-1-vinicius.gomes@intel.com>
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: Wed, 14 Mar 2018 13:32:09 -0700
> When errors are enqueued to the error queue via sock_queue_err_skb()
> function, it is possible that the waiting application is not notified.
>
> Calling 'sk->sk_data_ready()' would not notify applications that
> selected only POLLERR events in poll() (for example).
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Randy E. Witt <randy.e.witt@intel.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Applied and queued up for -stable, thank you.
Since this is going into 'net', it doesn't need to be in your net-next
submission as 'net' changes will (eventually) propagate into net-next.
Please fix that up, thank you.
prev parent reply other threads:[~2018-03-16 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 20:32 [PATCH net] skbuff: Fix not waking applications when errors are enqueued Vinicius Costa Gomes
2018-03-16 16:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316.123724.729271943170129684.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=randy.e.witt@intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox